iconbox "always on top"

Michael Andrews mandrews at mandrews.org
Sat Jun 26 20:45:39 CEST 2004

On Sat, 2004-06-26 at 13:59, Jasper Huijsmans wrote:
> Yeah, CVS panel is creating a dock type window (when always on top).
> This patch could be added for stable, if we agree this is a nice 
> feature. What do you think, does it make sense for the iconbox to follow 
> the panel's layer? It already does so for size, so it might just make sense.
> Even though it would make more sense to have these settings separate 
> from the panel, but that is definitely not for the stable branch.
> Michael, apart from that, there are a few things I'd like to see different:
> - remove the dependency on the panel, it's not needed

I put it in there to keep the global.h enum's for ABOVE, BELOW, NORMAL
in sync.  Since the panel is evidently changing a lot in CVS, I'll just
duplicate the enum (along with a note to keep it in sync).

> - put the code to change layer in the ls_iconboxwin_set_layer() function

OK.  It adds several new header files though.

> - the above two points mean there's no need to have the new files and 
> configure.ac, nor Makefile.am need to be changed.

Yup.  Pass 2 coming up.

> 	Jasper
> Olivier wrote:
> > Michael,
> > 
> > I think the panel uses a different layer scheme now (well, basically,
> > it's a dock). I don't know if the layers still apply...
> > 
> > Jasper? Any comment?
> > 
> > Cheers,
> > Olivier.
> > 
> > On Sat, 2004-06-26 at 19:02, Michael Andrews wrote:
> > 
> >>Excuse the repeat if you subscribe to the xfce-dev list, but the
> >>activity seems to be here.
> >>
> >>A couple of weeks ago on IRC, I threatened to modify the iconbox so that
> >>it was not longer "always on top" but instead use the layer setting from
> >>the panel (I despise "always on top").  Well, I actually did it.  I have
> >>uploaded the patch file to:
> >>
> >>  http://www.mandrews.org/iconbox_layer.patch
> >>
> >>If one of the core developers wants to consider it for "general
> >>release".  I can also email directly to the appropriate person.
> >>
> >>The patch looks a little long (28k), but about half of the patch appears
> >>to be due to the auto-generated Makefiles and configure scripts.  I
> >>updated the automake and autoconfig files, and am not sure I got them
> >>right (they build for me).
> >>
> >>Thanks,
> _______________________________________________
> Xfce4-dev mailing list
> Xfce4-dev at xfce.org
> http://lunar-linux.org/mailman/listinfo/xfce4-dev
Michael Andrews <mandrews at mandrews.org>

More information about the Xfce4-dev mailing list