xfwm4: alt+tab holds the system and probably leaks memory

[Brian J. Tarricone]

Olivier wrote:

>As for a mem leak, I'll check. Last time I checked, valgrind didn't
>report any mem leak.
>
yeah, i'm seeing it too.  it's rather small.  i think you're not freeing the GdkPixbuf that gets returned for the app icon.  client.c:3540, you call getAppIcon() as an argument to tabwinCreate().  getAppIcon() uses gdk_pixbuf_new_from_data(), which allocates memory for the pixel data.  tabwin.c:105, tabwinCreate() calls tabwinSetLabel(), which calls gtk_image_set_from_pixbuf().  after that call, it needs a g_object_unref() on the pixbuf, as the GtkImage will grab a reference of its own.  i could be missing something, of course, since i'm not so familiar with the xfwm4 codebase, but i think i'm right.

	-brian


>Cheers,
>Olivier.
>
>On Sun, 2004-06-20 at 10:55, Eduard Roccatello wrote:
>  
>
>>Hello friends,
>>keeping alt+tab pressed hold all the X processes (eg. xmms stop playing
>>while pressed). Benny told me it's a linux related issue.
>>Memory usage also grow when cycling icons so maybe a mem leak in it.
>>
>>Oliver, can you confirm this behaviour?
>>
>>Cheers,
>>    
>>