[patch] shortcut editor
Olivier
fourdan at xfce.org
Thu Jun 17 18:40:48 CEST 2004
Jean-Francois,
There is a show stopper with your patch: It doesn't build with gtk+-2.2
(because of GtkTreeVewSelection at least) which is the target for xfce
4.2, so it really needs to be fixed or I'll have to revert...
Cheers,
Olivier.
On Thu, 2004-06-17 at 08:20, Olivier wrote:
> Salut Jean-Francois
>
> Ok, commited with a few small changes. I changed the layout a bit to
> improve readbility in the treeviews, changed some labels, move the
> notebooks...
>
> I've also changed the identation of the code as I really don't like Java
> style indent.
>
> A few remarks:
>
> - The "browse" command button does nothing yet
> - The dialog displayed when waiting for the user to enter the shortcut
> needs a bit more work, like an icon or something;
> - I really think the code should be splitted in several sources, it's
> hard to browse a 3800+ lines source file :)
> - Please use the same indentation as I use for xfwm4,
>
> Thanks,
> Olivier
>
> On Wed, 2004-06-16 at 22:42, Jean-François Wauthy wrote:
> > I think the patch i wrote to add shortcut editing in xfwm4 is in final
> > stade, so i send to patch. What do you think about Olivier ?
--
- Olivier Fourdan - fourdan at xfce.org - http://www.xfce.org -
More information about the Xfce4-dev
mailing list