[Xfce4-commits] CVS: xfce4/libxfcegui4/libxfcegui4 dialogs.c, 1.24, 1.25

[Jasper Huijsmans]

pollux at lunar-linux.org wrote:
> Update of /var/cvs/xfce/xfce4/libxfcegui4/libxfcegui4
> In directory dbguin.lunar-linux.org:/tmp/cvs-serv21398
> 
> Modified Files:
> 	dialogs.c 
> Log Message:
> xfce_confirm 'cancel' button becomes a 'no' button if stock_id is GTK_STOCK_YES
> 

I'd like to take this opportunity to say something about dialog design. 
In general I think we should try and follow the GNOME HIG. This means 
that in general Yes/No or Ok/Cancel dialogs are not what you want.

The button order is <alternate action>  <cancel> <default action>.

So, instead of this:
------------------------------------------
Do you want to save changes to the file?

			     No	     Yes
------------------------------------------

We get this:
------------------------------------------
Do you want to save changes to the file?

	Discard changes    Cancel   Save
------------------------------------------


It's not a very big deal, but I think it's nicer and it makes us fit in 
better with GNOME applications, which is a good thing IMO.

	Jasper