[Xfce4-commits] CVS: xfce4/xfwm4-themes/themes/gorilla Makefile.am, 1.3, 1.4 Makefile.in, 1.7, 1.8

[Benedikt Meurer]

Olivier,

>  install-themeDATA:
> -	rm -Rf $(DESTDIR)$(themedir); \
> -	$(mkinstalldirs) $(DESTDIR)$(themedir); \
> -	tar cf - $(theme_DATA) | ( cd $(DESTDIR)$(themedir) ; tar xf - ); \
> -	if test `id -u` = "0"; then \
> -	    chown root:root $(DESTDIR)$(themedir); \
> -	    chown root:root $(DESTDIR)$(themedir)/*; \
> -	fi; \
> -	chmod 755 $(DESTDIR)$(themedir); \
> -	chmod 644 $(DESTDIR)$(themedir)/*
> +	rm -Rf $(DESTDIR)$(themedir); 					\
> +	$(mkinstalldirs) $(DESTDIR)$(themedir); 			\
> +	tar cf - $(theme_DATA) | (cd $(DESTDIR)$(themedir) ; tar xf - --no-same-owner)

Please revert this change, since it breaks w/ nearly every system, except 
those where tar is gtar. So, please, either use gtar or don't use GNU tar options.

BTW: How about the POSIX.2 way of doing things?

	pax -rw $(theme_DATA) $(DESTDIR)$(themedir)

This is simpler, tho some systems still don't ship pax. But I think every 
system that Xfce runs on is somewhat POSIX.2 compliant.

regards,
Benedikt

-- 
NetBSD Operating system:                       http://www.NetBSD.org/
pkgsrc "Work in progress":                  http://pkgsrc-wip.sf.net/
XFce desktop environment:                        http://www.xfce.org/
German Unix-AG Association:                   http://www.unix-ag.org/
os-network:                                 http://www.os-network.de/

OpenPGP Key: http://www.home.unix-ag.org/bmeurer/#gpg