BUG: taskbar crash

Olivier Fourdan fourdan at xfce.org
Mon Sep 22 20:31:53 CEST 2003


Humm, I dunno, it's benny's code, I've never took a look at it...

If if fixes the issue, then, go, shoot :)

Cheers,
Olivier.

On Mon, 2003-09-22 at 19:46, Jasper Huijsmans wrote:
> Op ma 22-09-2003, om 19:19 schreef Jasper Huijsmans:
> > Well, I can reproduce this. This doesn't really look like the systray
> > bug you fixed:
> > 
> 
> This patch fixes the issue for me. It calls the toggle_tray function in
> an idle loop.
> 
> This seemed to be happening: 
> * the notify_changed function in libxfce4mcs was waiting for
> client->notify_cb to finish because of the dialog
> * when you unheck the tray option notify_changed get called again. I
> assume this cahnges some pointers for the first instance or frees some
> memory.
> * then when you close the dialog the first instance of notify_changed
> will try to finish, but the damage caused by the second invocation makes
> it segfault.
> 
> Adding the idle loop makes the client->notify_cb return immediately,
> thus preventing the crash.
> 
> What do you think?
> 
> 	Jasper
> 
> ______________________________________________________________________
> _______________________________________________
> Xfce4-dev mailing list
> Xfce4-dev at xfce.org
> http://moongroup.com/mailman/listinfo/xfce4-dev
-- 
Olivier Fourdan - fourdan at xfce.org
   
   Interoperability is the keyword, uniformity is a dead end. 
   http://www.xfce.org






More information about the Xfce4-dev mailing list