BUG: taskbar crash

[Jasper Huijsmans]

Op ma 22-09-2003, om 19:19 schreef Jasper Huijsmans:
> Well, I can reproduce this. This doesn't really look like the systray
> bug you fixed:
> 

This patch fixes the issue for me. It calls the toggle_tray function in
an idle loop.

This seemed to be happening: 
* the notify_changed function in libxfce4mcs was waiting for
client->notify_cb to finish because of the dialog
* when you unheck the tray option notify_changed get called again. I
assume this cahnges some pointers for the first instance or frees some
memory.
* then when you close the dialog the first instance of notify_changed
will try to finish, but the damage caused by the second invocation makes
it segfault.

Adding the idle loop makes the client->notify_cb return immediately,
thus preventing the crash.

What do you think?

	Jasper
-------------- next part --------------
A non-text attachment was scrubbed...
Name: tray.patch
Type: text/x-patch
Size: 1207 bytes
Desc: not available
URL: <http://mail.xfce.org/pipermail/xfce4-dev/attachments/20030922/ea82ae04/attachment.bin>