Changes allowed before release (Was: Re: Bunch of (small) bug fixes in xfwm4)

[edscott wilson garcia]

On Sat, 2003-09-13 at 05:01, Olivier Fourdan wrote:
> Jsaper,
> 
> No, we keep latest format change, if it's buggy, then Edscott will deal
> with users :)

The changes were thoroughly checked. Even though many files were altered
in the last commit, the only ones that were *really* changed were
libs/reg.c and libs/reg.h. And I put in some compiler directives so that
the old code can be used instead: thus by modifying a single line in
each file, changes are reverted. Nonetheless, the advantages gained by
just changing the xffm.reg file to applications.xml are quite great:

1- The new code is simpler, shorter, faster, less bug prone and easier
to maintain. Take the following bug: open two xffm's. "Remember" a bunch
of program associations in xffm-1. Close xffm-1. "Remember" a single
program association in xffm-2. All you "remembered" with xffm-1 is now
"forgotten". This bug is solved with the xml format. I will not even try
to fix the bug using the old format (too hard to do).

2- The new code allows for the system wide
$PREFIX/xffm/applications.xml. This heals the bug which causes the
"can't load xffm.reg" warning.

3- The run autocompletion also feeds off the system wide
applications.xml, which extends the functionality for newbies.

In short, two bugs removed, easier to maintain code, extended
functionality. So dealing with the users will be a piece of cake
 :-)

regards,

Edscott

> 
> Cheers,
> Olivier.
> 
> On Sat, 2003-09-13 at 11:59, Jasper Huijsmans wrote:
> > Op za 13-09-2003, om 10:10 schreef Olivier Fourdan:
> > > Hi Edscott,
> > > 
> > > On Sat, 2003-09-13 at 04:03, edscott wilson garcia wrote:
> > > 
> > > > So we are looking at rc5 ;-)
> > > 
> > > No, I'm getting sick of this RC cycle.
> > > 
> > 
> > Hear, hear ;-)
> > 
> > > > I've also just updating xffm: the format of the program register has
> > > > changed to xml, which allowed to remove some small bugs and to enhance
> > > > the run combo autocompletion with a system wide file.
> > > 
> > > My changes are small, with few impact on the code. Changing a file
> > > format to XML after RC4 is definitely another matter... 
> > > 
> > > We'll ship as is, if xffm is buggy, so be it.
> > > 
> > 
> > Hmm, this is getting complicated in CVS. 
> > 
> > We need to change version numbers and I want to be able to update
> > translations and documentation before 4.0, but you don't want to use
> > this file format change.
> > 
> > So, perhaps we should create an xfce_4_0 branch in CVS at the rc4 tag
> > and do only the updates that don't really impact the code. After 4.0,
> > this branch can be used for bugfix releases 4.0.x.
> > 
> > New developments, 4.1.x releases, can then continue on the HEAD branch.
> > 
> > What's your opinion?
> > 
> > 	Jasper
> > 
> > 
> > 
> > _______________________________________________
> > Xfce4-dev mailing list
> > Xfce4-dev at xfce.org
> > http://moongroup.com/mailman/listinfo/xfce4-dev