Feature request: button icons should reflect the state (sticky, shaded, maximized)

[Olivier Fourdan]

Hi Jens,

I modified your patch to use 6 states (active, inactive, pressed, as
before, plus toggled-active, toggled-inactive and toggled-pressed) per
buttons instead of a separate array for toggled buttons.

It might waste a few bytes, but it make things more logical, consistent,
IMO. It allows a "toggled" + "pressed" state which was missing from your
patch.

I've also fixed the gtk theme (you've got to define the color
replacement inside the xpm, not just edit it with the gimp or any other
image editor... Open one I've modified and you'll understand what I
mean) - That's partly what requires the most work when designing a
theme.

I've also renamed the pixmap to use

maximize-toggled-active.xpm
maximize-toggled-inactive.xpm
maximize-toggled-pressed.xpm

shade-toggled-active.xpm
shade-toggled-inactive.xpm
shade-toggled-pressed.xpm

stick-toggled-active.xpm
stick-toggled-inactive.xpm
stick-toggled-pressed.xpm

It's all in CVS.

Cheers,
Olivier.

On Sun, 2003-03-16 at 21:17, Jens Guballa wrote:
> Hi,
> 
> On Sat, Mar 15, 2003 at 09:53:35PM +0100, Jens Guballa wrote:
> > Hi everybody,
> > 
> > as already mentioned in a previous mail, I think some title buttons
> > should reflect the state of the window, e.g. the icon for the
> > sticky-button should change if the window is made sticky. Beside the
> > sticky button also the shade and the maximize button should reflect the
> > corresponding state. This would require some more *.xpm files for the
> > themes. 
> > 
> > Themes that do not provide these new *.xpm files (yet) should not be
> > affected.
> > 
> > Before I start writing a patch I would like to hear other opinions.
> > Any thoughts?
> 
> In the meantime I wrote the patch. As an example I also included the
> necessary *.xpm files for the gtk-theme (not my favorite theme, but it
> was easy to create the icons).
> 
> I would be glad if this feature would become part of xfwm4.
> 
> Jens
-- 
Olivier Fourdan <fourdan at xfce.org>
http://www.xfce.org