xfdesktop

[Benedikt Meurer]

On Fri, 14, Mar 2003, Jasper Huijsmans wrote:

> On Fri, 14 Mar 2003 01:31:13 +0100
> Benedikt Meurer <Benedikt.Meurer at unix-ag.uni-siegen.de> wrote:
> 
> > Hello,
> > 
> > I updated some things in xfdesktop:
> > 
> > 	* autotools stuff (more updates to come)
> > 	* fixed some memory leaks (reading list files was broken), there
> > 	  are still some leaks in it
> > 	* xfdesktop now uses xfce_*() function family instead of
> > 	show_*()* xfdesktop now depends on libxfce4util
> > 	* some code cleanups
> > 	* misc stuff (e.g. use reader/writer locking on plattforms, that
> > 	  supports it)
> > 
> > Todo for now:
> > 
> > 	* put common code required by both xfdesktop itself and the
> > 	settings
> > 	  module into a common directory (already added to cvs)
> > 	* Fix the leftover memory leaks
> > 	* Maybe use the GLib XML parser to parse the menu.xml, libxml
> > 	  seems to be overhead.
> > 
> > Opinions?
> > 
> 
> Right, thanks.
> 
> Two questions:
> 
> Why do we need file locking?

To prevent data file corruption in any case.

> What's wrong with g_file_get_contents()?

a) a single read(2) is sufficient to read the contents of a regular file
   on UNIX systems
b) g_file_get_contents() does not use file locking.

> On a side note, I saw you removed the unused prevnumber variable.
> Apparently I wanted to make sure to not set the same backdrop twice, but
> forgot to implement that ;-) I still like the idea.

I'll implement that :)

regards,
Benedikt

-- 
Those who do not understand Unix are condemned to reinvent it, poorly.
    -- Henry Spencer