Patch for xfrun

[Jasper Huijsmans]

Hi,

They (the GTK maintainers) have been talking about replacing gtk combo
forever. As it seems now there may actually be a replacement in gtk 2.4,
but this is still several months away I think.

If GtkCombo uses a GtkList internally, as I'm sure it does, and you want
to use signals on that list, you will have to undefine
GTK_DISABLE_DEPRECATED.

As a side note, I have been wondering about the usefulness of the
'start in terminal' option in the run dialog. It seems to me it would be
just as easy or even easier to simply start a terminal in the first
place.

Idem for the open directory in xterm or filemanager feature. Why not
open that terminal or filemanager in the first place?

Just some thoughts,

	Jasper

On 11 Mar 2003 21:22:45 +0100
Olivier Fourdan <fourdan at xfce.org> wrote:

> James,
> 
> I'm a bit puzzled with the need of "undefining" GTK_DISABLE_DEPRECATED
> 
> Note that on a production build wel'' remove all that DEPRECATED
> defines as there is no way to tell what will be deprecated in the
> future. We use it during the devel phase only, to make sure the code
> we write now is not already deprecated :)
> 
> This said, would you mind asking the gtk-app-devel-list at gnome.org ?
> 
> Cheers,
> Olivier.
>  
> On Tue, 2003-03-11 at 20:32, James Tappin wrote:
> > Hi everyone.
> > 	Well I've done it -- the attached patch allows xfrun to remember
> > 	the
> > state of the "Run in terminal" setting in it's history. Basically it
> > just adds a 0 or 1 at the end of each line of the history file. It
> > handles old history files by assuming a zero if it doesn't find any
> > spaces.
> > 
> > The only thing I'm not really happy about is the need to 
> > #undef GTK_DISABLE_DEPRECATED
> > but that's really gtk+'s fault, the GtkCombo widget uses a
> > deprecated GtkList and so if you need to handle signals from the
> > list you need to deal with GtkList functions. This patch also
> > bundles the open a terminal or file manager in a directory
> > capability as well.
> > 
> > If it looks reasonable and works for other folks, please apply.
> > 
> > 	Best regards,
> > 		James
> -- 
> Olivier Fourdan <fourdan at xfce.org>
> http://www.xfce.org
> 
> _______________________________________________
> Xfce4-dev mailing list
> Xfce4-dev at xfce.org
> http://moongroup.com/mailman/listinfo/xfce4-dev