more on xffm

edscott wilson garcia edscott at imp.mx
Fri Feb 21 15:35:24 CET 2003


I've commited a fix using access() instead of opendir(). Should work.

BTW, I've reverted your last changes (addfile.c) of making files appear
at the end. The function you modified has a gboolean entry to be able to
choose whether they append or prepend. This should be used with a
configurable option instead of just removing the prepend line.

Edscott


El vie, 21-02-2003 a las 08:14, Jens Luedicke escribió:
> On Fri, 2003-02-21 at 14:33, Jens Luedicke wrote:
> > Hi ...
> > 
> > I found a new bug in xffm:
> > 
> > When trying to expand a directory without the correct
> > permissions, xffm enters a loop and re-tries again
> > and again to load/expand it and floods the text-view
> > with 'path/folder: Permission denied' messages.
> 
> xffm tried to add/load the folder contents (this failed in that case)
> and tried to expand the folder node (which caused another re-loading
> the folder) and so on.
> 
> this is a temporary workaround:
> 
> Index: callbacks.c
> ===================================================================
> RCS file: /cvsroot/xfce/xfce-devel/xffm/src/callbacks.c,v
> retrieving revision 1.26
> diff -u -r1.26 callbacks.c
> --- callbacks.c	13 Feb 2003 18:07:27 -0000	1.26
> +++ callbacks.c	21 Feb 2003 14:12:18 -0000
> @@ -185,7 +185,16 @@
>  			FILENAME (en), NULL);
>  	  while (gtk_events_pending ())
>  	    gtk_main_iteration ();
> +
> +	  printf("loading %s\n", en->path);
> +	  
> +	  if (!opendir(en->path)) {
> +		printf("can't load %s\n", en->path);
> +		goto time2return;
> +	  }
> +
>  	  add_folder (treeview, iter);
> +
>  	  gtk_tree_store_set ((GtkTreeStore *) treemodel, iter,
>  			      SIZE_COLUMN, sizetag (-1, en->count), -1);
>  
> 
> -- 
> Jens Luedicke <jens at irs-net.com>
> 
> "Never offend people with style when you can offend them with
> substance."
> --Sam Brown
> 
> 
> 
> _______________________________________________
> Xfce4-dev mailing list
> Xfce4-dev at moongroup.com
> http://moongroup.com/mailman/listinfo/xfce4-dev
> 





More information about the Xfce4-dev mailing list