xfdesktop not compiling on BSD

[edscott wilson garcia]

El mié, 12-02-2003 a las 22:24, Biju Chacko escribió:
> On Thu, 2003-02-13 at 00:43, Jasper Huijsmans wrote:
> > 
> > Ok, I just removed the _GCC_PREREQ tests. If you have gcc < 2.6 or a
> > non-gcc compiler don't enable debug. 
> > 
> > I'll let botsie worry about a proper fix if he still wants to. I think I
> > can live with this.
> 
> I've committed a fix for this. I just realised that the test was only
> required if you're using C++. Also removed some cruft that had collected
> up in the file.
> 

Bootsie:

It may or may not be broken. It does compile, but I get the following
warnings:

popup.c: In function `build_theme_menu':
popup.c:232: warning: passing arg 3 of `scandir' from incompatible
pointer type
sysmenus.c: In function `get_dir_entries':
sysmenus.c:219: warning: passing arg 3 of `scandir' from incompatible
pointer type
sysmenus.c:221: warning: passing arg 3 of `scandir' from incompatible
pointer type
sysmenus.c:228: warning: passing arg 3 of `scandir' from incompatible
pointer type
sysmenus.c: In function `menu_from_tree':
sysmenus.c:901: warning: passing arg 5 of `g_node_traverse' from
incompatible pointer type
sysmenus.c:910: warning: passing arg 5 of `g_node_traverse' from
incompatible pointer type

> BTW, I've broken the cardinal rule by not actually compiling the fix.
> I'm at a clients place, working on windows. So please use with caution
> and revert if it breaks. I'm fairly sure it won't though.
> 
> A quick query:
> 
> To undefine a macro function which is preferable?
> 
> #define DBG(fmt, args)	      /* define it to nothing */
> 
> or
> 
> #define DBG(fmt, args) do {} while(0) /* define it to a no-op */
> 
> I usually use the first but I'm told the latter is common in the kernel.

I like the first. The second looks like a hack.

Edscott

> 
> -- b
> 
> -- 
> -----------------------------------------------------------------------
> Biju 'botsie' Chacko                        biju_chacko at vsnl dot net
> http://www.symonds.net/~botsie          Public Key available on request
> -----------------------------------------------------------------------
> _______________________________________________
> Xfce4-dev mailing list
> Xfce4-dev at moongroup.com
> http://moongroup.com/mailman/listinfo/xfce4-dev
>