codeset bugfixes xffm

[edscott wilson garcia]

El mié, 09-04-2003 a las 16:04, Olivier Fourdan escribió:
> Hi Edscott,
> 
> 
> On Wed, 2003-04-09 at 21:32, Olivier Fourdan wrote:
> > Hi Edscott,
> > 
> > On Wed, 2003-04-09 at 05:13, edscott wilson garcia wrote:
> > >   I think all the codeset problems you noticed have now been fixed.
> > 
> > Well, no it's not fixed. I'll look into it if I can find any time.
> 
> 
> Ha!! I know!
> 
> You call g_locale_to_utf8() function even on localized messages!
> 
> E.g.: In dummies.c, I read :
> 
> s = g_locale_to_utf8(_("Reading..."), -1, &r_bytes, &w_bytes, NULL);

Hmm... That's very old code, from xfdiff4, when I was using iso8859-1
translation strings. It has no need to be anymore.

> 
> Since the translations are already in UTF8, The translation on
> "Reading..." in UTF8
> 
> By calling g_locale_to_utf8(), you transform UTF8 to UTF8 assuming that
> UTF8 is in the locale encoding! SO not surprisingly, you get wrong
> results if the locale is not UTF8...
> 
> Problem, this error is repeated all along the code :(

I've eliminate all the remaining g_locale_to_utf8 calls by now :)

Edscott
> 
> Cheers,
> -- 
> Olivier Fourdan <fourdan at xfce.org>
> http://www.xfce.org
> 
> _______________________________________________
> Xfce4-dev mailing list
> Xfce4-dev at xfce.org
> http://moongroup.com/mailman/listinfo/xfce4-dev
>