xffm updates, i18n still broken

[edscott wilson garcia]

El dom, 06-04-2003 a las 16:47, Olivier Fourdan escribió:
> Hi all,
> 
> I've made a few updates to xffm:
> - update POTFILES list (was outdated, missing files, etc.)
> - update xffm.pot (oudated as POTFILES was outdated)
> - update fr.po
> - update all po files (but I did not add missing translations :) )
> - add i18n support to xfdiff4
> 
> However, i18n is still broken in xffm as seen on the following
> screenshot :
> 
> http://www.xfce.org/archive/i18n-xffm-broken.png
> 
> I set the LANG to fr_FR (I know, I did not add UTF-8 on purpose, the
> applications should set that) but some text in the treeview does not use
> UTF-8 ("Réseau", "Système") while other in the menu correctly use it
> ("Aller à"). 
> 
> Odd.

Hmm... It looks like a missing consideration in the xffm code.  

> 
> Looks like some init is broken. Still, the following lines are present
> and correct :
> 
> #ifdef ENABLE_NLS
>     bindtextdomain(GETTEXT_PACKAGE, PACKAGE_LOCALE_DIR);
>     bind_textdomain_codeset(GETTEXT_PACKAGE, "UTF-8");
>     textdomain(GETTEXT_PACKAGE);
> #endif
> 
>     gtk_set_locale();
>     gtk_init(&argc, &argv);
> 
> So what's wrong ? I suspect it has something to do with the use of libs
> (libxffm) - I think the bind_textdomain_codeset should be redone at lib
> init (if any) because the lib is initted by ld.so (I think). Dunno.
> 
> If anybody has an idea...

I think it might be this line in src/treeview.c:
tag[i] = g_locale_to_utf8(_(root[i].label), -1, &r_bytes, &w_bytes,
NULL); 

I've changed it to a subroutine which checks if it is valid utf-8 before
acting. It might work ok now. 

Edscott


> 
> Cheers;
> -- 
> Olivier Fourdan <fourdan at xfce.org>
> http://www.xfce.org
> 
> _______________________________________________
> Xfce4-dev mailing list
> Xfce4-dev at xfce.org
> http://moongroup.com/mailman/listinfo/xfce4-dev
>