[XFCE4 CVS] Another minor update :)

[Xavier MAILLARD]

Olivier Fourdan <fourdan at xfce.org> disait récemment que :

> Xavier,
>
> I'm a little puzzled. Don't the size should be driven by the widget ? So
> why did you change just builtins.c ?
>
> In my opinion, the size request stuff should be in the clock widget
> rather than in the builtin.c file. This doesn't necessarily show with
> led mode, but I guess you'll have to use hacks to implement similar
> stuff for the digital mode. The size of the widget depends on the font
> used for the clock widget in digital mode, and that is know by the clock
> widget. So I wonder how you can do something similar for the digital
> mode in a clean manner. Don't forget that the user might specify a
> special font fot he clock widget in the .gtkrc file...
>

I totally agree with you but as you say, it's only a hack to get the
display bug away. I know it's not the best solution but I am learning
the GTK programming at the same time I am coding. That means that I
don't have (yet) enough experience to undestand all the internal of the
widget creation/manipulation. There are still things I'm confused with.

But definitely you are right and the next objective is to deal with the
internals and drive the size using the gtk_widget_set_size.

> I mean, since it's up to the widget to set its size, you could use tiny
> led size in tiny panel mode, medium led size in small and medium panel
> size and huge led size for large panel size and let the clock widget
> give you its prefered size using standard gtk size request events (if I
> remember well).
>

See above.

> I know I haven't put my hands in the clock/panel interaction design
> enough, so this question could sound out of scope, but it lokks more
> "natural" to me. 
>

It's also to me. Just a lack of skills. I will really have a look into
it as I said next step is to have digital mode working. So I already
have thought how things work and I don't have the choice. I have to deal
with the internal widget mix of a gtk widget. So don't worry about that
:)

Just let me time to well understand. I don't want to do dirty work. I'm
not evil even if getting the LED working is just a hack :)

> Cheers,

Thanks for your opinion
Cheers,

> Olivier.
>

zeDek
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 188 bytes
Desc: not available
URL: <http://mail.xfce.org/pipermail/xfce4-dev/attachments/20020924/49afd45b/attachment.pgp>