[XFCE4 CVS] Another minor update :)

[Olivier Fourdan]

Xavier,

I'm a little puzzled. Don't the size should be driven by the widget ? So
why did you change just builtins.c ?

In my opinion, the size request stuff should be in the clock widget
rather than in the builtin.c file. This doesn't necessarily show with
led mode, but I guess you'll have to use hacks to implement similar
stuff for the digital mode. The size of the widget depends on the font
used for the clock widget in digital mode, and that is know by the clock
widget. So I wonder how you can do something similar for the digital
mode in a clean manner. Don't forget that the user might specify a
special font fot he clock widget in the .gtkrc file...

I mean, since it's up to the widget to set its size, you could use tiny
led size in tiny panel mode, medium led size in small and medium panel
size and huge led size for large panel size and let the clock widget
give you its prefered size using standard gtk size request events (if I
remember well).

I know I haven't put my hands in the clock/panel interaction design
enough, so this question could sound out of scope, but it lokks more
"natural" to me. 

Cheers,
Olivier.

On Tue, 2002-09-24 at 18:12, Xavier MAILLARD wrote:
> Hi,
> 
> Following the numerous feedbacks (thanks btw), I made correction on the
> clock (LED mode only) and changes are available in the CVS now.
> 
> Jasper said on IRC :
>        "huysmans pats zeDek on the back. Good work!".
> 
> So it's up to you now to upgrade it or now.
> 
> As usually there will be probably some nasty bugs :) so feel free to report
> any of them in the ML or on IRC.
> 
> Next step, fix the DiGITAL mode.
> 
> Cheers,
> 
> zeDek
-- 
Olivier               <fourdan at xfce.org>            http://www.xfce.org
-----------------------------------------------------------------------
XFce is a lightweight  desktop  environment  for  various *NIX systems.
Designed for productivity,  it loads  and  executes  applications fast,
while conserving  system resources. XFce is all free software, released
under GNU General Public License.    Available from http://www.xfce.org