minor xfce4 CVS update

[Jasper Huijsmans]

On Tue, 17 Sep 2002 09:08:45 +0530
Biju Chacko <botsie at myrealbox.com> wrote:

> On Mon, 16 Sep 2002 23:52:00 +0200, Jasper Huijsmans wrote:

[...]

> > And just commit to CVS if you think something is ready to go in. No
> > need to send me the patch first unless you want my opinion on
> > something. We can always revert the changes if necessary ;-)
> 
> I disagree. Two reasons:
> 
> * You are the xfce4 maintainer, you need to know exactly what is  
> happening to the code. I'd expect the same courtesy with respect to
> xfdeskmenu.
> 

Sure, that's why I can tell if it's ok to commit directly. I meant for
cleanups of current code. New features / big changes should still be 
send to me first.

Here's my unofficial policy at the moment. It's ok to commit changes if:
* it's code you wrote yourself or related to a feature you added
* it's an obviously correct fix
* we discusssed it and I said it was ok to commit
* you are Olivier Fourdan ;-)

Of course that's basically just common sense (except for the last one
perhaps ;-).

> * I'm not too confident of my 'C' skills. :-)
> 

Well it's ok to send it to me as well. 

> > I need to do a proper code audit (of my own code that is), because
> > there are reports of memory corruption and I'm not feeling too sure
> > about some things myself. However, I don't think it will be before
> > the weekend that I'll find the time to start work on that. 
> > 
> > There are two changes that I think we need first:
> > 1) popups should be positioned next to the button in vertical mode,
> >    aligned to the top or the bottom.
> > 2) In vertical mode the move handles should be on the same side of
> > the
> >    panel (making it look more like the panel turned 90 degrees) or
> >    on top and at the bottom. Then we can allow traditional style
> >    without making it look strange.
> 
> I'll try to take a look at these issues, probably after a day or two.
> 

I might tak a look at it myself. I'll keep you posted. And BTW:

3) panel positioning in the dialog must offer some more options

> -- b
> 
> -- 
> ---------------------------------------------------------------------
> -- Biju 'botsie' Chacko                        biju_chacko at vsnl dot
> net http://www.symonds.net/~botsie
> ---------------------------------------------------------------------
> --
> 
> _______________________________________________
> Xfce4-dev mailing list
> Xfce4-dev at moongroup.com
> http://moongroup.com/mailman/listinfo/xfce4-dev


-- 
IRC channel: #xfce on irc.openprojects.net