[Xfce4-commits] [xfce/xfce4-settings] 09/37: color: Drop unneeded code

noreply at xfce.org noreply at xfce.org
Fri Feb 15 00:27:38 CET 2019


This is an automated email from the git hooks/post-receive script.

o   c   h   o   s   i       p   u   s   h   e   d       a       c   o   m   m   i   t       t   o       b   r   a   n   c   h       o   c   h   o   s   i   /   c   o   l   o   r   d   
   in repository xfce/xfce4-settings.

commit 1e48e8713e5e82fb736380a5e703747adb49def5
Author: Simon SteinbeiƟ <simon.steinbeiss at tttech.com>
Date:   Mon Feb 4 04:06:49 2019 +0100

    color: Drop unneeded code
---
 dialogs/color-settings/color-profile.c | 25 -------------------------
 dialogs/color-settings/color-profile.h |  1 -
 dialogs/color-settings/main.c          |  6 ------
 3 files changed, 32 deletions(-)

diff --git a/dialogs/color-settings/color-profile.c b/dialogs/color-settings/color-profile.c
index fb87e37..969057f 100644
--- a/dialogs/color-settings/color-profile.c
+++ b/dialogs/color-settings/color-profile.c
@@ -34,7 +34,6 @@ struct _ColorProfile
   CdDevice    *device;
   CdProfile   *profile;
   gboolean     is_default;
-  gchar       *sortable;
   GtkWidget   *widget_description;
   GtkWidget   *widget_image;
   GtkWidget   *widget_info;
@@ -202,13 +201,6 @@ color_profile_get_profile (ColorProfile *color_profile)
   return color_profile->profile;
 }
 
-const gchar *
-color_profile_get_sortable (ColorProfile *color_profile)
-{
-  g_return_val_if_fail (SETTINGS_IS_COLOR_PROFILE (color_profile), NULL);
-  return color_profile->sortable;
-}
-
 gboolean
 color_profile_get_is_default (ColorProfile *color_profile)
 {
@@ -279,7 +271,6 @@ color_profile_finalize (GObject *object)
   if (color_profile->profile_changed_id > 0)
     g_signal_handler_disconnect (color_profile->profile, color_profile->profile_changed_id);
 
-  g_free (color_profile->sortable);
   g_object_unref (color_profile->device);
   g_object_unref (color_profile->profile);
 
@@ -315,22 +306,6 @@ color_profile_constructed (GObject *object)
     g_signal_connect (color_profile->profile, "changed",
                       G_CALLBACK (color_profile_changed_cb), color_profile);
 
-  /* sort the profiles in the list by:
-   * 1. thier device (required)
-   * 2. the data source (so calibration profiles are listed before autogenerated ones)
-   * 3. the date the profiles were created (newest first)
-   * 4. the alpha sorting of the filename
-   */
-  /*
-  title = gcm_prefs_get_profile_title (color_profile->profile);
-  sortable_device = color_device_get_sortable_base (color_profile->device);
-  sortable_data_source = color_profile_get_profile_sort_data_source (color_profile->profile);
-  color_profile->sortable = g_strdup_printf ("%s-%s-%012" G_GINT64_FORMAT "-%s",
-                                    sortable_device,
-                                    sortable_data_source,
-                                    cd_profile_get_created (color_profile->profile),
-                                    title);
-*/
   color_profile_refresh (color_profile);
 }
 
diff --git a/dialogs/color-settings/color-profile.h b/dialogs/color-settings/color-profile.h
index 055d717..57ee9b4 100644
--- a/dialogs/color-settings/color-profile.h
+++ b/dialogs/color-settings/color-profile.h
@@ -37,6 +37,5 @@ void         color_profile_set_is_default   (ColorProfile  *color_profile,
                                                 gboolean         profile_is_default);
 CdDevice    *color_profile_get_device       (ColorProfile  *color_profile);
 CdProfile   *color_profile_get_profile      (ColorProfile  *color_profile);
-const gchar *color_profile_get_sortable     (ColorProfile  *color_profile);
 
 G_END_DECLS
diff --git a/dialogs/color-settings/main.c b/dialogs/color-settings/main.c
index d57fc23..2a7685d 100644
--- a/dialogs/color-settings/main.c
+++ b/dialogs/color-settings/main.c
@@ -413,8 +413,6 @@ color_settings_device_changed_cb (CdDevice *device, ColorSettings *settings)
     }
 
   color_settings_update_profile_list_extra_entry (settings);
-  /* resort */
-  //gtk_list_box_invalidate_sort (prefs->list_box);
 }
 
 
@@ -442,14 +440,10 @@ color_settings_add_device (ColorSettings *settings, CdDevice *device)
   gtk_container_add (GTK_CONTAINER (settings->list_box), widget);
   gtk_size_group_add_widget (settings->list_box_size, widget);
 
-  /* add profiles */
-  //color_settings_add_device_profiles (settings, device);
-
   /* watch for changes */
   g_ptr_array_add (settings->devices, g_object_ref (device));
   g_signal_connect (device, "changed",
                     G_CALLBACK (color_settings_device_changed_cb), settings);
-  gtk_list_box_invalidate_sort (settings->list_box);
 }
 
 

-- 
To stop receiving notification emails like this one, please contact
the administrator of this repository.


More information about the Xfce4-commits mailing list