[Xfce4-commits] <midori:master> Bail out of attach_inspector_cb if inspector_view didn't change

Christian Dywan noreply at xfce.org
Wed Mar 6 23:52:01 CET 2013


Updating branch refs/heads/master
         to 09df9ed5a69175ad1ce33845b12be0e4b3b05486 (commit)
       from b023b27a92838cb31e7986951271c4ac48bf2bf6 (commit)

commit 09df9ed5a69175ad1ce33845b12be0e4b3b05486
Author: Christian Dywan <christian at twotoasts.de>
Date:   Wed Mar 6 23:42:02 2013 +0100

    Bail out of attach_inspector_cb if inspector_view didn't change

 midori/midori-browser.c |    8 ++++----
 1 files changed, 4 insertions(+), 4 deletions(-)

diff --git a/midori/midori-browser.c b/midori/midori-browser.c
index 0dec76b..b42cd2c 100644
--- a/midori/midori-browser.c
+++ b/midori/midori-browser.c
@@ -1145,12 +1145,12 @@ midori_view_attach_inspector_cb (GtkWidget*     view,
                                  GtkWidget*     inspector_view,
                                  MidoriBrowser* browser)
 {
-    GtkWidget* toplevel;
-    GtkWidget* scrolled;
+    GtkWidget* toplevel = gtk_widget_get_toplevel (inspector_view);
+    GtkWidget* scrolled = gtk_widget_get_parent (browser->inspector_view);
+    if (browser->inspector_view == inspector_view)
+        return;
 
-    toplevel = gtk_widget_get_toplevel (inspector_view);
     gtk_widget_hide (toplevel);
-    scrolled = gtk_widget_get_parent (browser->inspector_view);
     gtk_widget_destroy (browser->inspector_view);
     gtk_widget_reparent (inspector_view, scrolled);
     gtk_widget_show_all (browser->inspector);


More information about the Xfce4-commits mailing list