[Xfce4-commits] <midori:master> Remove focus grabbing when showing suggestions

Christian Dywan noreply at xfce.org
Wed Jan 11 00:38:01 CET 2012


Updating branch refs/heads/master
         to 74ae33e2324543d9f9dcb0e37329b949b6a7cfc0 (commit)
       from 274cf6f9d8324a412681be46026bf4e1885f1456 (commit)

commit 74ae33e2324543d9f9dcb0e37329b949b6a7cfc0
Author: Alexander Butenko <a.butenka at gmail.com>
Date:   Sun Jan 8 09:26:50 2012 -0400

    Remove focus grabbing when showing suggestions

 extensions/formhistory/formhistory-gdom-frontend.c |   12 +++++-------
 1 files changed, 5 insertions(+), 7 deletions(-)

diff --git a/extensions/formhistory/formhistory-gdom-frontend.c b/extensions/formhistory/formhistory-gdom-frontend.c
index 5e4676d..2a91b1d 100644
--- a/extensions/formhistory/formhistory-gdom-frontend.c
+++ b/extensions/formhistory/formhistory-gdom-frontend.c
@@ -148,7 +148,6 @@ formhistory_reposition_popup (FormHistoryPriv* priv)
 
     /* Window configuration */
     gtk_window_set_screen (GTK_WINDOW (priv->popup), gtk_widget_get_screen (view));
-    /* FIXME: If Midori window is small, popup doesn't show up */
     gtk_window_set_transient_for (GTK_WINDOW (priv->popup), GTK_WINDOW (toplevel));
     gtk_tree_view_columns_autosize (GTK_TREE_VIEW (priv->treeview));
     /* FIXME: Adjust size according to treeview width and some reasonable height */
@@ -212,13 +211,12 @@ formhistory_suggestions_show (FormHistoryPriv* priv)
     }
     sqlite3_reset (stmt);
     sqlite3_clear_bindings (stmt);
-    gtk_widget_grab_focus (priv->treeview);
 
-    if (gtk_widget_get_visible (priv->popup))
-        return;
-    formhistory_reposition_popup (priv);
-    gtk_widget_show_all (priv->popup);
-    gtk_widget_grab_focus (priv->treeview);
+    if (!gtk_widget_get_visible (priv->popup))
+    {
+        formhistory_reposition_popup (priv);
+        gtk_widget_show_all (priv->popup);
+    }
 }
 
 static void


More information about the Xfce4-commits mailing list