[Xfce4-commits] <xfce4-xkb-plugin:master> Remove unnedeed g_strdup as g_strconcat already allocates memory. Pointed by Lionel Le Folgoc (#7363)

Azamat H. Hackimov noreply at xfce.org
Sun Apr 17 20:30:01 CEST 2011


Updating branch refs/heads/master
         to 192b3c3016c1690c4bd266d67a106e0bc8be9fcb (commit)
       from 48a3dbe0b418331a85939d3b25b95c150b2ecaef (commit)

commit 192b3c3016c1690c4bd266d67a106e0bc8be9fcb
Author: Azamat H. Hackimov <azamat.hackimov at gmail.com>
Date:   Mon Apr 18 00:25:44 2011 +0600

    Remove unnedeed g_strdup as g_strconcat already allocates memory.
    Pointed by Lionel Le Folgoc (#7363)

 panel-plugin/xkb-settings-dialog.c |    6 +++---
 1 files changed, 3 insertions(+), 3 deletions(-)

diff --git a/panel-plugin/xkb-settings-dialog.c b/panel-plugin/xkb-settings-dialog.c
index d8431a3..6c06612 100644
--- a/panel-plugin/xkb-settings-dialog.c
+++ b/panel-plugin/xkb-settings-dialog.c
@@ -875,11 +875,11 @@ xkb_settings_update_from_ui (t_xkb *xkb)
         if (is_default) xkb->settings->default_group = i;
         i++;
 
-        kbd_config->layouts = g_strdup(g_strconcat(kbd_config->layouts, ",", layouts, NULL));
+        kbd_config->layouts = g_strconcat(kbd_config->layouts, ",", layouts, NULL);
         if (variants != NULL)
-            kbd_config->variants = g_strdup(g_strconcat(kbd_config->variants, ",", variants, NULL));
+            kbd_config->variants = g_strconcat(kbd_config->variants, ",", variants, NULL);
         else
-            kbd_config->variants = g_strdup(g_strconcat(kbd_config->variants, ",", NULL));
+            kbd_config->variants = g_strconcat(kbd_config->variants, ",", NULL);
     }
     xkb_config_update_settings (xkb->settings);
     xkb_refresh_gui (xkb);



More information about the Xfce4-commits mailing list