backlight_helper_get_best_backlight()

[Jack Bates]

On 21/04/16 11:33 PM, Harald Judt wrote:
> Am 22.04.2016 um 02:56 schrieb Jack Bates:
>> Would you consider a patch to replace the list in
>> backlight_helper_get_best_backlight()
>> http://git.xfce.org/xfce/xfce4-power-manager/tree/src/xfpm-backlight-helper.c#n384
>
> Yes we could do that if you provide one. However...
>
>> with the same logic as here:
>> https://git.gnome.org/browse/gnome-settings-daemon/tree/plugins/power/gsd-backlight-linux.c#n61
>>
>> i.e. grab the first interface of type "firmware" and fall back on the
>> first interface of type "platform" and finally "raw".
>
> This seems to me like just another priority list. Can you tell/guarantee
> that this would be better than the current implementation?
>
> Isn't this just replacing the current implementation with another
> arbitrary solution using a priority list?

This is the commit that replaced the whitelist with the kernel-supplied 
backlight type in the GNOME source, and the rationale:
https://git.gnome.org/browse/gnome-settings-daemon/commit/plugins/power/gsd-backlight-helper.c?id=fff09fe17eecb9314962d119a5c5b4e865f2570d

I'd be happy to cook up and provide a patch for Xfce.