Localization lost in GtkBuilder interface file when using XFCE_LICENSE_*

[Brian J. Tarricone]

On Tue, Oct 20, 2009 at 17:08, Christoph Wickert
<christoph.wickert at googlemail.com> wrote:
> Am Dienstag, den 20.10.2009, 23:40 +0200 schrieb Ali Abdallah:
>
>> Disabling the call in libxfce4util or calling xfce_textdomain
>> (GETTEXT_PACKAGE, LOCALEDIR, "UTF-8"); again after closing the dialog
>> fixes the problem, no idea why.
>>
>> Please your comments.
>
> I reported a similar problem with Terminal 0.4.x (#5842) and the fix was
> trivial:
> http://git.xfce.org/apps/terminal/commit/?id=5c955bb0435dca6d7114903d246cf2e4a215cc5e

That's really a poor fix.  Libraries shouldn't be calling
xfce_textdomain().  They should include glib/gi18n-lib.h (instead of
glib/gi18n.h), which sets up the _() macro in such a way that it
passes GETTEXT_PACKAGE when making the gettext calls.  The i18n stuff
in libxfce4util probably isn't the best idea for libraries.

     -brian