several defects and enhacement-wishes

[Olivier Fourdan]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

samo wrote:
>> You were so kind and ask for that feature soooo nicely that I
>> couldn't resist and I have now added the feature in SVN. Of course,
>> I count on you for translating the new strings added by this
>> feature in the 46 languages within the following couple of days
>> (oh, and no need to send the french translation, I took care of
>> that myself). Yes, as you know, localization is part of usability,
>> and since we are so bad at that, I have to count on people like you
>> who are so knowledgeable.
>
> no, you are not bad, you are just not systematic. not that it 
> matters...
> and i don't think insulting helps any-direction.

Huh?? Who's insulting? Definitely not me. What I wrote is all true, the
menu short has been implemented and requires translation.

[...]

> you rely on ordering of these items - as in the handleKeyPress() 
> switch(). Why not make them enum? And put a comment-warning about 
> that order being important? i guess there are other similar ones..
> Or just remove them as direct names, and always use key_1 + index...

Enum or #define makes little difference if you screw it up by mistake
like I did...

> These could go into a table (key-attributes) + a loop over it.
> This would minimize maintenance issues - u'll have all them keys + 
> their attributes in one table, and different loops/"methods" to do 
> different things about them. Instead of having many copies of "same" 
> list of keys doing slightly different (but repeating) things over and 
> over and over.

Sure, the thing is that the code was all right with a few shortcuts, but
more and more are added and makes the thing messy now. Some day, it'll
require cleanup.

> oh, if u don't want me to comment about maintenability/quality of 
> code, bad-practices etc, just say so.

I have no problem with criticism, but I definitely prefer well written
patches.

Regards,
Olivier.
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.3 (GNU/Linux)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org

iD8DBQFFK+wGFHBtvh5LRUARApFjAJ9N1BrYRrqIBn8MvyJhic6xw+peYwCgmYEt
M0atjOdtOpb2zsORyGxYiHg=
=uYY4
-----END PGP SIGNATURE-----