xfce4-notes bug disrupts panel

[Erik Harrison]

On Wed, 16 Feb 2005 18:20:13 +0100, Ondrej Mihalyi <mihalyi at matfyz.cz> wrote:
> I was just hinking, if it is possible to some checking mechanism, that would not load "bad" plugin (removed it from panel conf) right the next time the panel is launched after crash.
> 
> What I mean is something like make a log record into log file (followed by fflush) for each plugin initialization and after succesful initialization of all plugins it would log succes.  Next time it could check the log file and find out whether the plugins loaded succesfully or not (in this case it would skip the last plugin logged)
> 
> It also happened to me, that a plugin (either xkbd plugin or another one) caused panel to crash immediately after launch and I had to find out, where is the cnfiguration for that panel plugin.  Think about a usual user - he just needs panel to 'just work' without any intervention., it doesn't matter whether some plugins load or not.
> 
> Just an idea, I have completely no knowledge of the panel's source code, so don't shout at me, if it is not possible :)
> 

Just off the top of my head, I would say that while this would be
handy for crashes on plugin load, it doesn't handle the more common
case of a plugin causing a crash later.

-Erik

> Cheers,
> 
> Ondrej
> 
> On Thu, 10 Feb 2005 18:04:05 -0800
> "Brian J. Tarricone" <bjt23 at cornell.edu> wrote:
> 
> > Angelina Carlton wrote:
> >
> > >I realize that xfce4 notes is part of the goodies package and I added
> > >a comment to an exisiting bug at the goodies bug tracker, however it
> > >seems it might affect xfce4-panel also.
> > >
> > >Xfce4-notes will choke if your note contains a special character like
> > >'&'
> > >
> > >
> > Just a random guess, but, assuming the config file is XML, I'd bet
> > someone forgot to call g_markup_escape_text() before writing note data
> > to the file.  The '&' character is special in XML and needs to be
> > escaped.  Granted, it occurs to me that I can't see why this would cause
> > a crash.
> >
> > >if I type a note "apples & oranges" the next time I login, notes wont
> > >load, but worse, my entire panel wont load. Does the panel not have
> > >a check for broken plugin?
> > >
> > It isn't really possible to do such a check.  To the panel, plugins are
> > black boxes.  Because plugins run in the same process space as the
> > panel, they can do all manner of evil things to it (even accidentally),
> > and there isn't much the panel can do about it.
> >
> > >Its easy to fix by editing the notes config file directly but want to
> > >let someone know about the panel not loading.
> > >
> > >
> > As you might guess at this point, the only solution to this is to fix
> > the notes plugin.
> >
> > /me kicks the notes plugin maintainer
> >
> >     -b
> > _______________________________________________
> > Xfce mailing list
> > Xfce at xfce.org
> > http://lunar-linux.org/mailman/listinfo/xfce
> > http://www.xfce.org
> >
> _______________________________________________
> Xfce mailing list
> Xfce at xfce.org
> http://foo-projects.org/mailman/listinfo/xfce
> http://www.xfce.org
> 


-- 
CAPS LOCK: ITS LIKE THE CRUISE CONTROL FOR AWESOME
-Erik