Uploaded CLAW again

[Chris Brault]

Ok, 
Here it is:

> still a few major problems:
> 1) claw2.py line 47: the string says "mime.xml " 
> <-- notice the extra 
> space at the end, won't find the file

FIXED
____________________________________________________

> 2) claw2.py line 1336: "IndexError: list index out
> of range" -  looks 
> like the 'extensions' array is larger than the
> 'pics' array, and so 
> we're running off the end of the 'pics' array since
> you're bounding 'y' 
> with 'range(len(extensions))'.

FIXED
_______________________________________________________

> 3) claw2.py line 1418: if the file doesn't exist
> (e.g. it's a symlink 
> pointing to nothing), we crash here (i temporarily
> changed it to 
> os.lstat(...) just to make it work)

FIXED
______________________________________________________

> then the minor/cosmetic stuff:
> 1) i have 599 files in my homedir, and the claw took
> ~15s just to start up

599 files? Wow, that's alot. Head to head, the CLAW is
was about 4 seconds slower opening up /usr/lib (1040
files on my computer). I have already done alot to
speed the CLAW up. There are some things that I could
do in batch mode and save time and some unnecessary
work I could cut out...that make take a bit though.
There is alot to do. The mime-type pics take the
longest. If I index those pictures, I bet it would be
as fast as xffm. (right now it is a hack, not a dirty
hack, but a hack nonetheless).

______________________________________________________

> 2) when i delete a file in my homedir, it appears to
> reread the entire directory, taking another 10-15s

In preferences there is a setting for that. It is "on"
by default at someone else's request (on #xfce). Erase
the ~/.claw/ directory, then check the preferences
dialog (there's a button on the tool bar). 

_____________________________________________________

> 3) when it started up, the tree view on the left was
> about 10 pixels wide

That is default size. Let me reset it to 120 pixels.

____________________________________________________

> 4) the treeview starts up without any "twisties" to
> expand branches, so 
> the folder icons are flush against the left side of
> the window.  if you 
> click on a folder, it opens, a twisty appears, and
> the folders shift to 
> the right.  not a major problem, but it's not all
> that aesthetically 
> pleasing either.

That is a minor thing there, whether or not to have
the drop-down arrows. However, the arrows only appear
when the contents of that directory are listed. So,
listing the contents of every member of the root file
system during startup just seemed too time consuming.
If you press me on this, though I will add an option
in the preferences for this.

___________________________________________________

> 5) when i click on an icon in the file view, there's
> no selection 
> box/highlight color, so i have no idea which item is
> selected (if there 
> is one at all).  perhaps that's just my theme, but i
> do know that other 
> apps get the highlighting correct.

I will add an option for select by "single click" or
by "shift-click" in the preferences dialog. I just
think that the shift click makes you think more about
what you are doing (i.e. safer)

______________________________________________________

> 6) the icon spacing in the file view is _huge_ - i
> suspect due to a few 
> exceptionally long file names on some files.  at any
> rate, my screen res 
> is 1600x1200, and the 6 columns of icons don't fit
> on one screen width.  
> best idea is to truncate names longer than X and
> append an ellipsis to 
> the end.  also, the # of columns should be
> configurable based on window 
> size and/or screen width.

The wrap function I use is pretty lame at best. Let me
set a few numbers to make things work better. I'll
wrap at 12 letters of the line is longer that 20
characters.

_____________________________________________________

> 7) main toolbar - several of the buttons are
> toggles, and should be 
> ToggleButtons rather than regular Buttons

Aren't we mister picky today ... I use a repeating
function to create those buttons. That would require
me making the buttons individually ... it is done (I
used toggle buttons, so there).

_________________________________________________

> 8) once i'm in a directory, if i click or double
> click on another folder 
> in the tree, nothing happens.  i have to right click
> and click 'open' to actually get the files.  this 
> isn't terribly intuitive (or necessary).

So you want a quick opener instead of a quick browser.
The idea behind that was that you can go as deep as
yout want, without committing. Perhaps you just want
to check to see if a file is there and do nothing. Or
perhaps you want to explore deeper before opening the
files. I mean, who decides at which level we auto
open?
That is a tough call man. I'll think about it.

______________________________________________________

> 9) just my personal preference, but the "auto resize
> main window" 
> feature seems a little silly.  when i tried it, i
> navigated from my 
> homedir (with the huge window) to a directory with a
> single file in it - 
> the window shrunk to this tiny, unusable thing,
> about 5% its original size.

Well, you can still use the toolbars. The auto resize
has a big button on top for untoggling that. ROX
includes this feature, and since, even
unintentionally, my widget seems to follow ROX's lead,
this feature is included. If I hear a cacophony of
complaints about it, I'll make it off by default.

______________________________________________________

> 10) when i clicked the "toggles showing hidden
> files" button, my machine 
> shot to 100% cpu and the app froze for about 7
> seconds.  there was only 
> one file in the directory i had selected (none
> hidden), so i don't know 
> what the holdup is.

Well, it actually reloads the directory to keep the
hidden files in alphabetical order. You're thinking
that I should add them to the table without relisting
the directory in it's entirety. I could write that
function, but it would be time consuming and this is
such a trivial matter. I mean, how often do people
with half a million items with outrageously long file
names decide to view their hidden directories anyways?

_______________________________________________________

> 11) if i enable the second file pane, click in it,
> and then disable it, 
> if i try to open other directories, they
> (presumably) get opened in the 
> 2nd pane (which is hidden).  i shouldn't need to
> click back on pane #1 
> after hiding the 2nd one.

Oops, heh, heh, heh. One line of code I left out
there. 
FIXED.
_______________________________________________________

> 12) the menu in the tree pane behaves differently
> than in the file 
> pane.  in the tree pane, a right click followed by a
> release causes the 
> menu to appear, then disappear.  in the file pane, a
> click causes the 
> menu to appear, and the release leaves it there
> (unless you select a 
> menu item, of course).

This is it's default behavior, about which I can do
little. List menu's are different than popup windows
for gtk.Widgets.

______________________________________________________

> 13) right click->open on a file doesn't work -
> python reports 
> "TypeError: fileMenuClicked() takes exactly 5
> arguments (4 given)".  
> double click seems to work tho.

FIXED

______________________________________________________


> 14) if i drag a directory into the 'bookmarks' list,
> the 'Empty' item 
> does not disappear.  if i delete everything in the
> list, the 'Empty' 
> item does not reappear.  personally i'd say scrap
> the label entirely, i 
> think an empty list is pretty self-explanatory.

I saw the empty in mozilla and thought, hey, why not,
if they do it ... I probably should get rid of it.

_____________________________________________________

> overall it's a cool filebrowser.  it just needs a
> bit of polish.
> 
>     -brian

Spit and Polish on the way.

P.S.: Remember to delete the ~/.claw/ directory before
running the new versions until I get the unknown
mime-type dialog up and running.

P.S. 2: Is there any developer out there that gives
this kind of fast responce and delivery? And who has
so much fun doing it? Probably not.

__________________________________
Do you Yahoo!?
Yahoo! Finance: Get your refund fast by filing online.
http://taxes.yahoo.com/filing.html