[Xfce-bugs] [Bug 16763] patch for xfce-shortcuts-grabber.c which wrongly ungrabs keys when updating grabbed ones

[bugzilla-daemon at xfce.org]

https://bugzilla.xfce.org/show_bug.cgi?id=16763

--- Comment #23 from Conrad Meyer <cem at FreeBSD.org> ---
(In reply to Landry Breuil from comment #20)
> i dont really understand the following justification for 8 value in the
> freebsd patch:
> 
> that means 'one will probably not remap more than 8 physical keys to the
> same keycode', right ? in that case, i think it makes sense somehow..

Yeah, it's just an arbitrary number.  The GDK API looked like multiple keycodes
could be mapped to a single keyval.  I arbitrarily chose 8 as an unlikely high
number of keycodes to be mapped to a keyval, but it is just a guess.  I have
little familiarity with GDK or X.  It would be fine to refactor it to allocate
the saved keycodes array dynamically, or to bump the number up.

-- 
You are receiving this mail because:
You are the assignee for the bug.