[Xfce-bugs] [Bug 16763] patch for xfce-shortcuts-grabber.c which wrongly ungrabs keys when updating grabbed ones

bugzilla-daemon at xfce.org bugzilla-daemon at xfce.org
Sat May 16 10:13:37 CEST 2020


--- Comment #22 from Guido Falsi <madpilot at FreeBSD.org> ---
(In reply to Landry Breuil from comment #20)
> i dont really understand the following justification for 8 value in the
> freebsd patch:
> +   * An arbitrary number of keys may generate the same keyval.  Rather than
> add
> +   * memory allocation to this path, I just constrained the unmapping
> behavior
> +   * to 8 identically coded keys.  It seems unlikely?  But I am no xkeyboard
> +   * expert.
> that means 'one will probably not remap more than 8 physical keys to the
> same keycode', right ? in that case, i think it makes sense somehow..

cem at FreeBSD.org, who originally created the patch (I only did minor changes and
submitted it) can correct me if I'm wrong. He knows better for sure.

I understand that comment and the code the way you do. But if strictly required
the patch can be modified with memory allocation for the buffer, it looks a
little overkill though.

I posted cem patch almost as is, but I am open to suggestions and requests to
make it better.

You are receiving this mail because:
You are the assignee for the bug.

More information about the Xfce-bugs mailing list