[Xfce-bugs] [Bug 15727] Replacing a file via Cut and Paste in the same filesystem makes a copy

bugzilla-daemon at xfce.org bugzilla-daemon at xfce.org
Sat Aug 24 18:04:27 CEST 2019


Reuben Green <reubengreen73 at gmail.com> changed:

           What    |Removed                     |Added
   Attachment #8898|0                           |1
        is obsolete|                            |

--- Comment #13 from Reuben Green <reubengreen73 at gmail.com> ---
Created attachment 8954
  --> https://bugzilla.xfce.org/attachment.cgi?id=8954&action=edit
patch to allow native file move in overwrite with user confirmation

Latest version of the patch.

The patch contains two commits as before, with the first containing a few new
lines to prevent memory leaks. The second commit, like the previous version,
allows the use of native operations when overwriting a file by retrying (after
asking for user confirmation) with the G_FILE_COPY_OVERWRITE flag added if the
first g_file_move fails with error G_IO_ERROR_EXISTS. This version differs from
the previous one in that it adds an extra member to ThunarTransferNode to
record whether the user has confirmed file replacement (to prevent the user
being asked twice), and also in that it only invokes thunar's fallback
copy+delete for a small set of possible G_IO_ERROR_* errors where it makes
sense to do so (taking the behaviour of nautilus as a guide).

Criticisms and suggestions for improvement are welcome!

You are receiving this mail because:
You are the assignee for the bug.

More information about the Xfce-bugs mailing list