[Xfce-bugs] [Bug 15727] Replacing a file via Cut and Paste in the same filesystem makes a copy

[bugzilla-daemon at xfce.org]

https://bugzilla.xfce.org/show_bug.cgi?id=15727

Reuben Green <reubengreen73 at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Attachment #8881|0                           |1
        is obsolete|                            |

--- Comment #6 from Reuben Green <reubengreen73 at gmail.com> ---
Created attachment 8898
  --> https://bugzilla.xfce.org/attachment.cgi?id=8898&action=edit
patch to allow native file move in overwrite with user confirmation

Apologies for the newbie errors! Here is a revised patch containing the same
changes as the previous ones, but split into two commits and with spaces not
tabs.

I have had a look through the code and I don't think thunar_job_ask_replace can
return THUNAR_JOB_RESPONSE_RETRY. Indeed, the direct "return" statements in
thunar_job_ask_replace only use THUNAR_JOB_RESPONSE_CANCEL, _YES, and _NO.
thunar_job_ask_replace does call thunar_job_real_ask_replace (indirectly, via
the call to exo_job_emit on line 439 in thunar-job.c), which in turn calls
thunar_job_real_ask (via the call to g_signal_emit on line 251), but these only
return _CANCEL, _YES, _YES_ALL, _NO, _NO_ALL (and thunar_job_ask_replace
converts _YES_ALL and _NO_ALL to _YES and _NO).

-- 
You are receiving this mail because:
You are the assignee for the bug.