[Xfce-bugs] [Bug 14576] Add support for folder.jpg

[bugzilla-daemon at xfce.org]

https://bugzilla.xfce.org/show_bug.cgi?id=14576

--- Comment #12 from alexxcons <acs82 at gmx.de> ---
thanks, seems like you fixed it, now the patch works fine for me.

Some further improvement suggestions for your patch to prevent memory leaking:
- the return value of g_strconcat always need to be freed. Currently there is
the risk that only one string is freed (if
thunar_icon_factory_check_folder_icon  returns on the last "if" statement)
- as well when thunar_icon_factory_check_folder_icon return NULL, the srings 
build by g_strconcat need to be freed ( or when icon == NULL )

If you add a new patch to the issue which replaces old patches, you can select
all your older patches in the "Obsoletes:" list, to mark them as not valid any
more.

However as said above, I would prefer a patch which makes use of gvfs metadata.
We could recycle most of the nautilus code for that I think.

-- 
You are receiving this mail because:
You are the assignee for the bug.