[Goodies-dev] [Bug 13366] xfce4-mount-plugin-1.1.0 takes all rows of the panel

[bugzilla-daemon at xfce.org]

https://bugzilla.xfce.org/show_bug.cgi?id=13366

Fabian Nowak <timystery at arcor.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
         Resolution|---                         |FIXED

--- Comment #1 from Fabian Nowak <timystery at arcor.de> ---
Thanks for the hint. I wouldn't call the current behaviour "incorrect" and the
one created by you "correct". 

As a maintainer of a plugin that has more than 10 years of age, you don't check
the HIGs very frequently. Apart from that, many of the documentation is
umaintained, out of date, incomplete, and there even has been a request for
development guidelines on the mailing list recently. The row feature is rather
new in comparison to the plugin itself.

There hasn't been any other feedback apart from yours concerning the expansion
over several rows. From the provided screenshot, however, it really seems more
appropriate to not expand the entire panel over all rows (or columns in
vertical mode). From the cited documentation, it is rather the oppposite: "set
to small if in single row", and it is curently not set to small, but apears as
a single row. Maybe the API and/or documentation is broken there as well? IIRC
I even checked the cited documentation and for that reason changed the argument
in set_small to what it is now.

With the mode checks, the plugin might indeed break compatibility with older
panel versions; however, to the best of my knowledge GTK3 support as required
by the new mount plugin version is not available for older panels. Hence, the
mode checks are not expected to bring in any side effects.

Fixed in released version 1.1.1.

-- 
You are receiving this mail because:
You are the QA Contact for the bug.