[Goodies-dev] [Bug 13366] New: xfce4-mount-plugin-1.1.0 takes all rows of the panel
bugzilla-daemon at xfce.org
bugzilla-daemon at xfce.org
Sun Feb 19 00:29:58 CET 2017
https://bugzilla.xfce.org/show_bug.cgi?id=13366
Bug ID: 13366
Summary: xfce4-mount-plugin-1.1.0 takes all rows of the panel
Classification: Panel Plugins
Product: Xfce4-mount-plugin
Version: unspecified
Hardware: PC (x86_64)
OS: Linux
Status: NEW
Severity: normal
Priority: Medium
Component: General
Assignee: timystery at arcor.de
Reporter: maciekm at gmail.com
QA Contact: goodies-dev at xfce.org
Target Milestone: ---
Created attachment 7008
--> https://bugzilla.xfce.org/attachment.cgi?id=7008&action=edit
Screenshots of xfce4-mount-plugin-0.6.7 and xfce4-mount-plugin-1.1.0
After upgrading from v0.6.7 to v1.1.0, the mount plugin takes the whole panel
size (size of all rows), as shown on the attached screenshot.
I compared the sources and found the line
xfce_panel_plugin_set_small (plugin, TRUE);
was changed to
xfce_panel_plugin_set_small (plugin, FALSE);
As mentioned on the page:
https://wiki.xfce.org/dev/hig/panel-plugins
"plugins should set the small property (using xfce_panel_plugin_set_small())
only if they are intended to render on a single row, and not in deskbar mode."
I am not a SW developer, but looking at the code of another plugin, I replaced:
xfce_panel_plugin_set_small (plugin, FALSE);
with the following:
if (xfce_panel_plugin_get_mode(plugin) == XFCE_PANEL_PLUGIN_MODE_DESKBAR)
xfce_panel_plugin_set_small(plugin, FALSE);
else
xfce_panel_plugin_set_small(plugin, TRUE);
It seems to work correctly now, the plugin takes space on one row only. But I
can't tell if the change has side effects.
--
You are receiving this mail because:
You are the QA Contact for the bug.
More information about the Goodies-dev
mailing list