[Goodies-dev] Xfce power manager 0.6.0 released

[Ali Abdallah]

> Message: 2
> Date: Tue, 27 Jan 2009 17:24:29 +0100
> From: Jannis Pohlmann <jannis at xfce.org>
> Subject: Re: [Goodies-dev] Xfce power manager 0.6.0 released
> To: goodies-dev at xfce.org
> Message-ID: <20090127172429.1e0482ae at orion>
> Content-Type: text/plain; charset="us-ascii"
>
> Am Tue, 27 Jan 2009 17:18:36 +0100
> schrieb Ali Abdallah <aliov at xfce.org>:
>
>   
>>> Hey,
>>>
>>> Am Mon, 26 Jan 2009 15:49:29 +0100
>>> schrieb Ali Abdallah <aliov at xfce.org>:
>>>
>>>   
>>>       
>>>> Hi all,
>>>>
>>>> I'm happy to announce the first stable version of the xfce power
>>>> manager 0.6.0.
>>>>     
>>>>         
>>> I was just trying to include xfce4-power-manager in the goodies
>>> installer for Xfce 4.6RC1 when it failed to compile:
>>>
>>> xfpm-main.c: In function ___show_version___:
>>> xfpm-main.c:72: error: ___LC_ALL___ undeclared (first use in this
>>> function) xfpm-main.c:72: error: (Each undeclared identifier is
>>> reported only once xfpm-main.c:72: error: for each function it
>>> appears in.) make[2]: *** [xfce4_power_manager-xfpm-main.o] Error 1
>>>
>>>   
>>>       
>> Hi,
>>
>> I wasn't able to reproduce this in my setups, but removing the line
>> 72 in xfpm-main.c setlocal(LC_ALL,""); will fix the problem, 0.6.0 is 
>> already out
>> so what i have to do to include the power manager in the installer ?
>>     
>
> Release a bugfix version ;)
>
>   

I'll do that, do you have estimated time when the RC2 will be released.

>   - Jannis
>
>   
Ali.

> Message: 3
> Date: Tue, 27 Jan 2009 17:34:13 +0100
> From: Harold <xfce at sait.nl>
> Subject: Re: [Goodies-dev] Xfce power manager 0.6.0 released
> To: Xfce Goodies development discussion <goodies-dev at xfce.org>
> Message-ID: <1fd443de2344f6bd83e4ecfbe4ab7a57 at localhost>
> Content-Type: text/plain; charset="UTF-8"
>
> On Mon, 26 Jan 2009 15:49:29 +0100, Ali Abdallah <aliov at xfce.org> wrote:
>   
>> Hi all,
>>
>> I'm happy to announce the first stable version of the xfce power manager 
>> 0.6.0.
>>     
>
> Congratulations!
>
> I, however, am experiencing some strange behaviors and like to add
> something to the TODO list:
>
> * When running it on my desktop, the 'monitor settings' tab doesn't show
> the monitor settings
>   

Please open a bug report, i need more information here.
> * the '-r' command line option is a bit redundant. When no CLI options are
> given, the daemon should start (IMHO)
>   
will be in the next bug fix release.

> * Doubleclicking the tray icon should open the preferences window
> * A tooltip could display the current CPU governor and/or monitor settings
>
> These observations were made using xfce4-power-manager from SVN revision
> 6571...
>
>
>   
I consider these as TODO for the next version

> -H-
>
>
>   
Thanks,
Ali.

> ------------------------------
>
> Message: 4
> Date: Tue, 27 Jan 2009 18:07:42 +0100
> From: Enrico Tr?ger <enrico.troeger at uvena.de>
> Subject: Re: [Goodies-dev] Xfce power manager 0.6.0 released
> To: goodies-dev at xfce.org
> Message-ID: <20090127180742.478af5c0.enrico.troeger at uvena.de>
> Content-Type: text/plain; charset="us-ascii"
>
> On Tue, 27 Jan 2009 17:18:36 +0100, Ali Abdallah <aliov at xfce.org> wrote:
>
>   
>>> Hey,
>>>
>>> Am Mon, 26 Jan 2009 15:49:29 +0100
>>> schrieb Ali Abdallah <aliov at xfce.org>:
>>>
>>>   
>>>       
>>>> Hi all,
>>>>
>>>> I'm happy to announce the first stable version of the xfce power
>>>> manager 0.6.0.
>>>>     
>>>>         
>>> I was just trying to include xfce4-power-manager in the goodies
>>> installer for Xfce 4.6RC1 when it failed to compile:
>>>
>>> xfpm-main.c: In function ___show_version___:
>>> xfpm-main.c:72: error: ___LC_ALL___ undeclared (first use in this
>>> function) xfpm-main.c:72: error: (Each undeclared identifier is
>>> reported only once xfpm-main.c:72: error: for each function it
>>> appears in.) make[2]: *** [xfce4_power_manager-xfpm-main.o] Error 1
>>>
>>>   
>>>       
>> Hi,
>>
>> I wasn't able to reproduce this in my setups, but removing the line 72 
>> in xfpm-main.c setlocal(LC_ALL,""); will fix the problem, 0.6.0 is 
>>     
>
> Or fix it properly by including locale.h which is necessary when using
> setlocale(). Read its manpage.
> I think the fact that it worked for you without the header is more or
> less just a coincidence, to be portable you should include the header,
> see the attached patch.
>
>   
Yes i know, i removed the locale.h header long time, but i don't know how
the setlocale() escaped from me.

> Regards,
> Enrico
>
>   
Regards and thanks,
Ali.