[Goodies-dev] Xfce power manager 0.6.0 released

[Enrico Tröger]

On Tue, 27 Jan 2009 17:18:36 +0100, Ali Abdallah <aliov at xfce.org> wrote:

>>
>>
>> Hey,
>>
>> Am Mon, 26 Jan 2009 15:49:29 +0100
>> schrieb Ali Abdallah <aliov at xfce.org>:
>>
>>   
>>> Hi all,
>>>
>>> I'm happy to announce the first stable version of the xfce power
>>> manager 0.6.0.
>>>     
>>
>> I was just trying to include xfce4-power-manager in the goodies
>> installer for Xfce 4.6RC1 when it failed to compile:
>>
>> xfpm-main.c: In function ___show_version___:
>> xfpm-main.c:72: error: ___LC_ALL___ undeclared (first use in this
>> function) xfpm-main.c:72: error: (Each undeclared identifier is
>> reported only once xfpm-main.c:72: error: for each function it
>> appears in.) make[2]: *** [xfce4_power_manager-xfpm-main.o] Error 1
>>
>>   
>
>Hi,
>
>I wasn't able to reproduce this in my setups, but removing the line 72 
>in xfpm-main.c setlocal(LC_ALL,""); will fix the problem, 0.6.0 is 

Or fix it properly by including locale.h which is necessary when using
setlocale(). Read its manpage.
I think the fact that it worked for you without the header is more or
less just a coincidence, to be portable you should include the header,
see the attached patch.

Regards,
Enrico

-- 
Get my GPG key from http://www.uvena.de/pub.asc
-------------- next part --------------
A non-text attachment was scrubbed...
Name: xfce_pwr_manager_locale_fix.patch
Type: text/x-diff
Size: 306 bytes
Desc: not available
URL: <http://mail.xfce.org/pipermail/goodies-dev/attachments/20090127/1259f91f/attachment.patch>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 197 bytes
Desc: not available
URL: <http://mail.xfce.org/pipermail/goodies-dev/attachments/20090127/1259f91f/attachment.pgp>