[Goodies-dev] xfce4-sensors-plugin: hddtemp not setuid message

[Fabian Nowak]

Yeah,

hddtemp had nice error codes and lost some of them, as far as I see. 

so when you print out the regular return code via echo $? after
hddtemp /dev/hda, you will see it's rather messed up with all the codes.

In svn, the fd stuff is fixed, so this does not relate directly but
indirectly to each other. Wishlist: nice error codes of hddtemp or an
easy-to-use API...

Let's see what I can achieve this evening; also with regard to the mem
leaks.

Cheers, Fabian

Am Dienstag, den 26.02.2008, 02:44 -0200 schrieb Mariano Besio:
> Hi people, I've just installed version sensors plugin 0.10.99.4 from
> Debian reps (please keep reading), which is based on svn revision 3775
> and the new plugin started to show a message each time its started
> saying that hddtemp is not being setuid root. The problem is that it
> seems to be setuid correctly and hddtemp can be executed as non-root
> user without any trouble. So I decided to look after the code of svn
> version to fix it and found that get_hddtemp_value routine has on line
> 299 a validation with the access function against 0. Looking at access
> man pages, shouldn't this value be -1? I think that this is causing
> the message to appear when the disk string is "/dev/fd".
> 
> Thanks for all the work and nice plugins!
> Regars,
>