[Goodies-dev] fsguard: Added bar display and further improvements

[mmassonnet at gmail.com]

On Wed, Oct 03, 2007 at 10:25:49PM +0200, Robert Lange wrote:
> Hi,

Hi,

I guess we are synced with our hacking :s  I did the same work, and I
hope you won't be like “pissed off” if I tell you that some hours ago I
commited my stuff to svn.  Lets see the diff and increase the TODO list.

> About one year ago I wrote in this place that I am adding a free space
> bar graph to the fsguard plugin. I also asked for access to SVN, but
> somehow it got lost.

And we both didn't have much time, and time was passing, and the former
maintainer told us “unless you absolutely refuse to, please take over
maintenance”[0].

[0] http://foo-projects.org/pipermail/goodies-dev/2007-January/000565.html

> Anyway, now I am finished with the modification I want to do and
> wondering how would be the best way to proceed.

Someone asked me on IRC about the changes for fsguard, and my answer was
that I will get to it this week, which I did today.  What a coincidence
to read your mail now!

> Major improvements are:
> * Add bar display to visualise amount of left disk space
Check.
> * Optionally display free space in panel
Check.
> * Tooltip also shows disk capacity, not only left space
Check.

> You can find the code and some more comments at
> http://sethdepot.org/xfce4-fsguard-plugin-rola/
> It is based on the source code version (0.3.99, SVN revision 3285)
> 
> Main problem is of course that it's only tested to a certain extend - by
> myself on two computers.
> So from my point of view more testing is needed before it is ready for
> production release :-)
> Any suggestions what's the best way to get the patch into the project?
> When there are some documentation about the process, kindly point me to it.

The biggest difference with your patch is that I did code cleanup
furthermore adding stuff.  I prefer the label for the size before the
progress bar because it accomodates the other plugins (systemload,
netload, ...).  This size label should be mixed with the “label” IMHO
(which I renamed to “Name”).  And finally add an option to hide the
button, but not to choice either the button or the progress bar.

All this stuff is already in TODO[1].

[1] http://svn.xfce.org/svn/goodies/xfce4-fsguard-plugin/trunk/TODO


> Thanks,
> Robert

Best Regards,
Mike