[Goodies-dev] xfce4-cpugraph-plugin version 0.4.0 (lidiriel)

[gatopeich]

Liridiel, I see you intention is good.

About ownership, this is not my plugin :-). Better think of it as belonging to its users.

Look at it from the *user* point of view: what would you think if one of your favorite apps suddenly acts completely different in the new release, and the features you liked are just not there anymore? Will you look at the changelog? And feel better because someone promised to fix it later?

Refactoring is hard, precisely because you are not supposed to break functionality in the process.

Let's do this:
1.- Revert this patch, so existing users (like me) keep their favorite features.
2.- I help you with the refactoring. I am familiar with existing code, it won't be that bad.
3.- You introduce your features.

Is it a plan?
gatopeich.-

----- Mensaje original ----
Re: Any reason for removing most existing features? -
      xfce4-cpugraph-plugin version 0.4.0 (lidiriel)

Hi Gatopeich,

ooooh :(

I have "dither" (i don't know the correct english expression) to upload
 
this release (it is a low activity in this subversion directory) but If
 
your are hungry revert my change ... I hope that there change will be 
helpful in the future.

If you read changelog and other stuff i write that other feature are 
come back in next release.

In my point of view is not very good to place all the code in one file.
 
Difficult to read and keep stable etc.

I decided to split in several files for facilitate the next development
 
and for add more feature.

cpu_os : os information
option : create and manage configuration panel
mode : graphic and color mode
setting : read/write the configuration
cpu : core of plugin
I will have the possibility to add the net load plugin inside.

In the next week i think will work for reintroduce code in this order :
*BSD code
timescaling
fire color mode
frequency mode

And i you refuse the refactoring of your code, it's ok i will not work 
on your xfce plugin... and the admin can close my svn account...

Regards


Lidiriel






gatopeich wrote:
> Hi Liridiel,
> 
> According to the Changelog you just removed all existing graphic 
> features/modes, including the ones I recently added:
> 
> 2007-11-22  ludovic mercier  <lidiriel at coriolys.org>
> 
>     * panel-plugin: Split code in several files, cleanup and 
>     refactoring code. Remove timescaling, remove *BSD code, remove 
>     fire color and frequency modes.
>     Add bar graph for each cpu core.
>     Add grid view mode
>     Add associate command (default is xterm top)
> 
> Any _solid_ reason for that?
> 
> Usually, features are removed if they are not useful.
> 
> Particularly, I find the log-time-scale and frequency-shading
 features 
> very nice. I don't need just another boring cpu monitor... That's why
 I 
> made the effort to integrate them seamlessly within the existing 
> application, without breaking anything. Then, I made my dear features
 
> *optional*, to leave the user the choice. Get where I am going?
> 
> Also you seem to have changed everything around. Maybe you intend to 
> actively maintain the applet in the future, do you? Otherwise it is
 not 
> very wise to turn things the way _you_ like it.
> 
> I hope to be wrong, but this seems to me like you felt like making 
> *your* CPU monitor *the* CPU monitor and just pushed *your* code in, 
> bashing aside anybody else's.
> 
> I would advise to revert the thing, work a little bit in integrating 
> your features with the existing ones, then submit atomical changes,
 each 
> one representing a single logical step instead of a big bunch of
 mixed 
> changes.
> 
> Regards,
> gatopeich.-
> 
> gatoguan-os at yahoo.com




-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.xfce.org/pipermail/goodies-dev/attachments/20071123/470ed99c/attachment.html>