[Goodies-commits] r7065 - in xfce4-clipman-plugin/trunk: . panel-plugin

[Mike Massonnet]

Author: mmassonnet
Date: 2009-03-31 13:38:59 +0000 (Tue, 31 Mar 2009)
New Revision: 7065

Modified:
   xfce4-clipman-plugin/trunk/ChangeLog
   xfce4-clipman-plugin/trunk/panel-plugin/panel-plugin.c
Log:
Save/Load the history in the correct order

Modified: xfce4-clipman-plugin/trunk/ChangeLog
===================================================================
--- xfce4-clipman-plugin/trunk/ChangeLog	2009-03-31 06:48:39 UTC (rev 7064)
+++ xfce4-clipman-plugin/trunk/ChangeLog	2009-03-31 13:38:59 UTC (rev 7065)
@@ -1,3 +1,13 @@
+2009-03-31	Mike Massonnet
+Save/Load the history in the correct order
+
+	- panel-plugin/panel-plugin.c(panel_plugin_save):
+		Obviously I was sure I did that already, but then no trace in
+		the logs, so once again, the history was displayed in the
+		reverse order each time the plugin restarted, so the list is
+		reversed before being saved.  Also free the memory allocated
+		to texts as it has to even if there is no texts to be saved.
+
 2009-03-30	Mike Massonnet
 Redesign the actions settings dialog
 
@@ -8,7 +18,6 @@
 		Implement the new callbacks.  Set the settings dialog
 		back to transient and put it inside a window group (cause
 		gtk_dialog_run makes the dialog modal, cf. bug #4977).
-		group + make it transient
 	- panel-plugin/xfce4-clipman-actions.xml.in:
 		Change the regex' a little bit.
 

Modified: xfce4-clipman-plugin/trunk/panel-plugin/panel-plugin.c
===================================================================
--- xfce4-clipman-plugin/trunk/panel-plugin/panel-plugin.c	2009-03-31 06:48:39 UTC (rev 7064)
+++ xfce4-clipman-plugin/trunk/panel-plugin/panel-plugin.c	2009-03-31 13:38:59 UTC (rev 7065)
@@ -368,6 +368,7 @@
 
   /* Save the history */
   list = clipman_history_get_list (plugin->history);
+  list = g_slist_reverse (list);
   if (list != NULL)
     {
       texts = g_malloc0 (g_slist_length (list) * sizeof (gchar *));
@@ -407,9 +408,9 @@
           g_key_file_free (keyfile);
           g_free (data);
           g_free (filename);
-          g_free (texts);
         }
 
+      g_free (texts);
       g_slist_free (list);
     }
 }