[Goodies-commits] r6866 - in xfce4-screenshooter/trunk: . lib
Jerome Guelfucci
jeromeg at xfce.org
Sun Mar 8 16:46:04 CET 2009
Author: jeromeg
Date: 2009-03-08 15:46:04 +0000 (Sun, 08 Mar 2009)
New Revision: 6866
Modified:
xfce4-screenshooter/trunk/ChangeLog
xfce4-screenshooter/trunk/TODO
xfce4-screenshooter/trunk/lib/screenshooter-dialogs.c
Log:
Patch by Mike Massonnet to improve the main dialog.
Modified: xfce4-screenshooter/trunk/ChangeLog
===================================================================
--- xfce4-screenshooter/trunk/ChangeLog 2009-03-08 11:05:28 UTC (rev 6865)
+++ xfce4-screenshooter/trunk/ChangeLog 2009-03-08 15:46:04 UTC (rev 6866)
@@ -1,10 +1,23 @@
2009-03-08 jeromeg
+ Patch from Mike Massonnet.
+
+ * lib/screenshooter-dialogs.c (screenshooter_dialog_new):
+ - use "Ok" and "Cancel" buttons to make the layout cleaner.
+ - do not display a separator to be consistent with other goodies.
+ - improve the label of the mouse check box.
+ - add a subtitile for the dialog.
+ - the dialog does not need to be resizable, widgets are not resized
+ dynamically.
+ - tweak the spacing of the delay spin button box.
+
+2009-03-08 jeromeg
+
Now, when taking a region screenshot, the Escape key cancels everything.
* lib/screenshooter-actions.c: don't do anything if the screenshot is
NULL.
- * lib/screenshooter-utils.c
+ * lib/screenshooter-utils.c:
- include the keysim header.
- (get_rectangle_screenshot):
+ grab the keyboard.
Modified: xfce4-screenshooter/trunk/TODO
===================================================================
--- xfce4-screenshooter/trunk/TODO 2009-03-08 11:05:28 UTC (rev 6865)
+++ xfce4-screenshooter/trunk/TODO 2009-03-08 15:46:04 UTC (rev 6866)
@@ -1,6 +1,5 @@
* Port "select a region" to use cairo to have transparent rubber banding
as in thunar and xfdesktop.
-* When selecting a region, Escape should cancel everything.
* Check for leaks using valgrind.
* Use Xshape to have a transparent background in the generated screenshots.
Modified: xfce4-screenshooter/trunk/lib/screenshooter-dialogs.c
===================================================================
--- xfce4-screenshooter/trunk/lib/screenshooter-dialogs.c 2009-03-08 11:05:28 UTC (rev 6865)
+++ xfce4-screenshooter/trunk/lib/screenshooter-dialogs.c 2009-03-08 15:46:04 UTC (rev 6866)
@@ -479,23 +479,26 @@
if (!plugin)
{
dlg =
- xfce_titled_dialog_new_with_buttons (_("Take a screenshot"),
+ xfce_titled_dialog_new_with_buttons (_("Screenshot"),
NULL,
- GTK_DIALOG_DESTROY_WITH_PARENT,
+ GTK_DIALOG_DESTROY_WITH_PARENT|GTK_DIALOG_NO_SEPARATOR,
GTK_STOCK_HELP,
GTK_RESPONSE_HELP,
- GTK_STOCK_CLOSE,
+ GTK_STOCK_CANCEL,
GTK_RESPONSE_CANCEL,
- _("Take"),
+ GTK_STOCK_OK,
GTK_RESPONSE_OK,
NULL);
+
+ xfce_titled_dialog_set_subtitle (XFCE_TITLED_DIALOG (dlg),
+ _("Take a screenshot"));
}
else
{
dlg =
xfce_titled_dialog_new_with_buttons (_("Screenshot"),
NULL,
- GTK_DIALOG_DESTROY_WITH_PARENT,
+ GTK_DIALOG_DESTROY_WITH_PARENT|GTK_DIALOG_NO_SEPARATOR,
GTK_STOCK_HELP,
GTK_RESPONSE_HELP,
GTK_STOCK_CLOSE,
@@ -507,6 +510,7 @@
}
gtk_window_set_position (GTK_WINDOW (dlg), GTK_WIN_POS_CENTER);
+ gtk_window_set_resizable (GTK_WINDOW (dlg), FALSE);
gtk_container_set_border_width (GTK_CONTAINER (dlg), 0);
gtk_window_set_icon_name (GTK_WINDOW (dlg), "applets-screenshooter");
@@ -620,7 +624,7 @@
/* Create show mouse checkbox */
show_mouse_checkbox =
- gtk_check_button_new_with_label (_("Display the mouse pointer on the screenshot"));
+ gtk_check_button_new_with_label (_("Capture the mouse pointer"));
gtk_toggle_button_set_active (GTK_TOGGLE_BUTTON (show_mouse_checkbox),
(sd->show_mouse == 1));
@@ -669,7 +673,7 @@
/* Create delay spinner */
- delay_spinner_box = gtk_hbox_new(FALSE, 12);
+ delay_spinner_box = gtk_hbox_new(FALSE, 4);
gtk_widget_show (delay_spinner_box);
More information about the Goodies-commits
mailing list