[Goodies-commits] r7691 - in xfce4-screenshooter/trunk: . lib

[Jerome Guelfucci]

Author: jeromeg
Date: 2009-07-07 21:56:01 +0000 (Tue, 07 Jul 2009)
New Revision: 7691

Modified:
   xfce4-screenshooter/trunk/ChangeLog
   xfce4-screenshooter/trunk/lib/screenshooter-zimagez.c
Log:
Fix ZimageZ login with UTF-8 characters.

g_strreverse should not be used with UTF-8 strings! Also fix the error
checking for the logout method, which is by the way broken (upstream
has been contacted for this).


Modified: xfce4-screenshooter/trunk/ChangeLog
===================================================================
--- xfce4-screenshooter/trunk/ChangeLog	2009-07-07 21:16:04 UTC (rev 7690)
+++ xfce4-screenshooter/trunk/ChangeLog	2009-07-07 21:56:01 UTC (rev 7691)
@@ -1,5 +1,13 @@
 2009-07-07 jeromeg
 
+Fix ZimageZ login with UTF-8 characters.
+
+g_strreverse should not be used with UTF-8 strings! Also fix the error
+checking for the logout method, which is by the way broken (upstream
+has been contacted for this).
+
+2009-07-07 jeromeg
+
 Use libsoup instead of XMLRPC-C.
 
 Add libsoup as a dependency, remove the XMLRPC-C stuff. Factorize the

Modified: xfce4-screenshooter/trunk/lib/screenshooter-zimagez.c
===================================================================
--- xfce4-screenshooter/trunk/lib/screenshooter-zimagez.c	2009-07-07 21:16:04 UTC (rev 7690)
+++ xfce4-screenshooter/trunk/lib/screenshooter-zimagez.c	2009-07-07 21:56:01 UTC (rev 7691)
@@ -378,7 +378,7 @@
           continue;
         }
 
-      encoded_password = g_strdup (g_strreverse (rot13 (password)));
+      encoded_password = g_utf8_strreverse (rot13 (password), -1);
 
       TRACE ("User: %s", user);
       TRACE ("Encoded password: %s", encoded_password);
@@ -598,11 +598,9 @@
              G_TYPE_STRING, login_response,
              G_TYPE_INVALID);
 
-  if (tmp_error)
-    g_error_free (tmp_error);
+  if (G_IS_VALUE (&response_value))
+    g_value_unset (&response_value);
 
-  g_value_unset (&response_value);
-
   /* Clean the soup session */
   soup_session_abort (session);
   g_object_unref (session);
@@ -610,6 +608,13 @@
 
   screenshooter_job_image_uploaded (job, online_file_name);
 
+  if (tmp_error)
+    {
+      g_propagate_error (error, tmp_error);
+
+      return FALSE;
+    }
+
   return TRUE;
 }