<div><div>Hi, Alex.<br></div><div>thank you for your sugestions.<br></div><div><br></div><div>Here is my cloned repo: <br></div><div><a href="https://github.com/vfjpl/xfce4-power-manager">https://github.com/vfjpl/xfce4-power-manager</a><br></div><div><br></div><div>For now only cleanup and style changes. If you are ok with them then I will think about next steps.<br></div><div><br></div><div>Cheers,<br></div><div>Kacper<br></div></div><div class="nh_extra"><p>Dnia 29 marca 2019 23:22 Alex <acs82@gmx.de> napisał(a):<br></p><blockquote class="nh_quote" style="border-left: 2px solid #999; padding-left: 8px; margin: 0;"><div id="gwp1b63590d"><div id="gwp1b63590dh"><div text="#000000" bgcolor="#FFFFFF" class="gwp1b63590db" data-message-body="true"><div class="gwp1b63590d_moz-cite-prefix">Hi,<br></div><div class="gwp1b63590d_moz-cite-prefix"><br></div><div class="gwp1b63590d_moz-cite-prefix">thanks for your effort.<br></div><div class="gwp1b63590d_moz-cite-prefix"><br></div><div class="gwp1b63590d_moz-cite-prefix">It would be good to have many small
      commits, each doing a single cleanup step, instead of one giant
      commit.<br></div><div class="gwp1b63590d_moz-cite-prefix"><br></div><div class="gwp1b63590d_moz-cite-prefix">Specially exchanging methods (
      xfconf_channel_new / xfconf_channel_get ) IMO should happen in a
      dedicated commit.  Reading the doc, I would agree that the channel
      does not need to be released, since it is not mentioned, like in
      xfconf_channel_new.<br></div><div class="gwp1b63590d_moz-cite-prefix"><span class="highlight" style="background-color:rgb(255, 255, 255)"><span class="colour" style="color:rgb(0, 0, 0)"><span class="font" style="font-family:cantarell, sans-serif"><span class="size" style="font-size:medium">"The reference
        count of the returned channel is owned by libxfconf." ... so I
        guess </span></span></span></span><span class="highlight" style="background-color:rgb(255, 255, 255)"><span class="colour" style="color:rgb(0, 0, 0)"><span class="font" style="font-family:cantarell, sans-serif"><span class="size" style="font-size:medium"><span class="highlight" style="background-color:rgb(255, 255, 255)"><span class="colour" style="color:rgb(0, 0, 0)"><span class="font" style="font-family:cantarell, sans-serif"><span class="size" style="font-size:medium">libxfconf will free the object when
          the refcount reaches zero.</span></span></span></span></span></span></span></span><br></div><div class="gwp1b63590d_moz-cite-prefix"><br></div><div class="gwp1b63590d_moz-cite-prefix">Since we dont have gitlab yet, it would
      be nice if you could upload your power-manager branch on your
      personal e.g. gitlab/github/others account, so that we can put
      comments on specific lines.<br></div><div class="gwp1b63590d_moz-cite-prefix"><br></div><div class="gwp1b63590d_moz-cite-prefix">Cheers,<br></div><div class="gwp1b63590d_moz-cite-prefix">Alex<br></div><p><br></p></div><div>_______________________________________________<br></div></div><div>Xfce4-dev mailing list<br></div><div><a nh-compose-link="" href="mailto:Xfce4-dev@xfce.org">Xfce4-dev@xfce.org</a><br></div><div><a href="https://mail.xfce.org/mailman/listinfo/xfce4-dev" nh-safe-redirect="" data-saferedirecturl="https://zasobygwp.pl/redirect?sig=baeb807547a45f7f2cc39635bfa14998fb20ae741f72ee8a2cc8c3fe03963b5a&url=aHR0cHM6Ly9tYWlsLnhmY2Uub3JnL21haWxtYW4vbGlzdGluZm8veGZjZTQtZGV2&platform=desktop&brand=o2" target="_blank">https://mail.xfce.org/mailman/listinfo/xfce4-dev</a><br></div></div></blockquote></div><div><br></div>