<html>
<head>
<meta http-equiv="Content-Type" content="text/html; charset=UTF-8">
</head>
<body text="#000000" bgcolor="#FFFFFF">
<div class="moz-cite-prefix">Hi,</div>
<div class="moz-cite-prefix"><br>
</div>
<div class="moz-cite-prefix">thanks for your effort.</div>
<div class="moz-cite-prefix"><br>
</div>
<div class="moz-cite-prefix">It would be good to have many small
commits, each doing a single cleanup step, instead of one giant
commit.</div>
<div class="moz-cite-prefix"><br>
</div>
<div class="moz-cite-prefix">Specially exchanging methods (
xfconf_channel_new / xfconf_channel_get ) IMO should happen in a
dedicated commit. Reading the doc, I would agree that the channel
does not need to be released, since it is not mentioned, like in
xfconf_channel_new.</div>
<div class="moz-cite-prefix"><span style="color: rgb(0, 0, 0);
font-family: cantarell, sans-serif; font-size: medium;
font-style: normal; font-variant-caps: normal; font-weight:
normal; letter-spacing: normal; orphans: auto; text-align:
start; text-indent: 0px; text-transform: none; white-space:
normal; widows: auto; word-spacing: 0px;
-webkit-tap-highlight-color: rgba(0, 0, 0, 0.4);
-webkit-text-stroke-width: 0px; background-color: rgb(255, 255,
255); display: inline !important; float: none;">"The reference
count of the returned channel is owned by libxfconf." ... so I
guess </span><span style="color: rgb(0, 0, 0); font-family:
cantarell, sans-serif; font-size: medium; font-style: normal;
font-variant-caps: normal; font-weight: normal; letter-spacing:
normal; orphans: auto; text-align: start; text-indent: 0px;
text-transform: none; white-space: normal; widows: auto;
word-spacing: 0px; -webkit-tap-highlight-color: rgba(0, 0, 0,
0.4); -webkit-text-stroke-width: 0px; background-color: rgb(255,
255, 255); display: inline !important; float: none;"><span
style="color: rgb(0, 0, 0); font-family: cantarell,
sans-serif; font-size: medium; font-style: normal;
font-variant-caps: normal; font-weight: normal;
letter-spacing: normal; orphans: auto; text-align: start;
text-indent: 0px; text-transform: none; white-space: normal;
widows: auto; word-spacing: 0px; -webkit-tap-highlight-color:
rgba(0, 0, 0, 0.4); -webkit-text-stroke-width: 0px;
background-color: rgb(255, 255, 255); display: inline
!important; float: none;">libxfconf will free the object when
the refcount reaches zero.<br>
</span></span></div>
<div class="moz-cite-prefix"><br>
</div>
<div class="moz-cite-prefix">Since we dont have gitlab yet, it would
be nice if you could upload your power-manager branch on your
personal e.g. gitlab/github/others account, so that we can put
comments on specific lines.<br>
</div>
<div class="moz-cite-prefix"><br>
</div>
<div class="moz-cite-prefix">Cheers,</div>
<div class="moz-cite-prefix">Alex<br>
</div>
<div class="moz-cite-prefix"><br>
</div>
<div class="moz-cite-prefix">Am 28.03.19 um 16:21 schrieb cosiekvfj:<br>
</div>
<blockquote type="cite"
cite="mid:02a90347b5924451b12904b9ea8e8e70@grupawp.pl">
<meta http-equiv="content-type" content="text/html; charset=UTF-8">
<div>Hello. I'm working on some bugs in Power Manager. This is
mostly cleanup for later. <br>
</div>
<div>Please review.<br>
</div>
<br>
<fieldset class="mimeAttachmentHeader"></fieldset>
<pre class="moz-quote-pre" wrap="">_______________________________________________
Xfce4-dev mailing list
<a class="moz-txt-link-abbreviated" href="mailto:Xfce4-dev@xfce.org">Xfce4-dev@xfce.org</a>
<a class="moz-txt-link-freetext" href="https://mail.xfce.org/mailman/listinfo/xfce4-dev">https://mail.xfce.org/mailman/listinfo/xfce4-dev</a></pre>
</blockquote>
<p><br>
</p>
</body>
</html>