<div dir="ltr"><div><div><div>Hi Ali,<br></div>Thanks for the heads up, this was already fixed by <span class="gmail-from"><span class="gmail-user gmail-color-20">Skunnyk:<br><a href="https://github.com/andreldm/thunar/commit/e2dfd9da9996b53999d1a9934e3f8c6e9f7de209">https://github.com/andreldm/thunar/commit/e2dfd9da9996b53999d1a9934e3f8c6e9f7de209</a><br><br></span></span></div><span class="gmail-from"><span class="gmail-user gmail-color-20">Cheers,<br></span></span></div><span class="gmail-from"><span class="gmail-user gmail-color-20">Andre Miranda<br></span></span></div><div class="gmail_extra"><br><div class="gmail_quote">On Tue, May 9, 2017 at 10:08 AM, Ali <span dir="ltr"><<a href="mailto:aliovx@gmail.com" target="_blank">aliovx@gmail.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
  
    
  
  <div text="#000000" bgcolor="#FFFFFF">
    <p>Hi Francesco,</p>
    <p>This effectively can happen, the call might fail and it does not
      set a reason for the failure. I assume you are initializing your
      error pointer, you can like the following<span class="m_-3380205898582356286keywordflow"></span><br>
      <span class="m_-3380205898582356286keywordflow"></span></p>
    <pre class="m_-3380205898582356286fragment"><span class="m_-3380205898582356286keywordflow">...</span>
<span class="m_-3380205898582356286keywordflow">GError *error = NULL;</span>
<span class="m_-3380205898582356286keywordflow">result = g_dbus_proxy_call_finish(<wbr>proxy, res, &error);

if</span> (error != NULL) {
    g_warning(<span class="m_-3380205898582356286stringliteral">"... %s"</span>, error->message);
    g_error_free(error);
    <span class="m_-3380205898582356286keywordflow">return</span>;
}

<span class="m_-3380205898582356286keywordflow">if</span> (result == NULL) {
  g_warning(<span class="m_-3380205898582356286stringliteral">"Failed with no specific error"</span>);
  <span class="m_-3380205898582356286keywordflow">return</span>;
}
</pre>
    Cheers,<br>
    Ali<br>
    <br>
    <div class="m_-3380205898582356286moz-cite-prefix">On 04/29/2017 05:26 PM, Francesco Pasa
      wrote:<br>
    </div>
    <blockquote type="cite">
      <div dir="ltr">
        <div class="gmail_default" style="font-family:verdana,sans-serif">Hi All,<br>
          <br>
        </div>
        <div class="gmail_default" style="font-family:verdana,sans-serif">I am debugging the GTK3
          port of Thunar. We have a rather serious bug affecting almost
          all file operations (copy, rename, move, etc), which results
          in a crash (segfault) of the program. I debugged a little and
          it seems that the error is coming from the funtion<br>
          <br>
          <pre class="m_-3380205898582356286gmail-programlisting"><a href="https://developer.gnome.org/gio/glib-GVariant.html#GVariant" target="_blank"><span class="m_-3380205898582356286gmail-returnvalue">GVariant</span></a> *
g_dbus_proxy_call_finish (<em class="m_-3380205898582356286gmail-parameter"><code><a class="m_-3380205898582356286gmail-link" href="https://developer.gnome.org/gio/stable/GDBusProxy.html" title="GDBusProxy" target="_blank"><span class="m_-3380205898582356286gmail-type">GDBusProxy</span></a> *proxy</code></em>,
                          <em class="m_-3380205898582356286gmail-parameter"><code><a class="m_-3380205898582356286gmail-link" href="https://developer.gnome.org/gio/stable/GAsyncResult.html" title="GAsyncResult" target="_blank"><span class="m_-3380205898582356286gmail-type">GAsyncResult</span></a> *res</code></em>,
                          <em class="m_-3380205898582356286gmail-parameter"><code><a href="https://developer.gnome.org/gio/glib-Error-Reporting.html#GError" target="_blank"><span class="m_-3380205898582356286gmail-type">GError</span></a> **error</code></em>);</pre>
        </div>
        <div class="gmail_default" style="font-family:verdana,sans-serif">which is supposed to
          return NULL in case of errors, and fill the error pointer with
          a description of the error. It does return NULL, but the error
          pointer seems to be uninitialized (the bug goes away if I
          manually fill the error pointer with some random data and
          g_error_new).<br>
          <br>
        </div>
        <div class="gmail_default" style="font-family:verdana,sans-serif">Does somebody now if
          this is a bug in glib? <br>
          <br>
        </div>
        <div class="gmail_default" style="font-family:verdana,sans-serif">Thanks in advance,<br>
        </div>
        <div class="gmail_default" style="font-family:verdana,sans-serif">Francesco Pasa<br>
        </div>
        <div class="gmail_default" style="font-family:verdana,sans-serif"><br>
          <br>
        </div>
      </div>
      <br>
      <fieldset class="m_-3380205898582356286mimeAttachmentHeader"></fieldset>
      <br>
      <pre>______________________________<wbr>_________________
Xfce4-dev mailing list
<a class="m_-3380205898582356286moz-txt-link-abbreviated" href="mailto:Xfce4-dev@xfce.org" target="_blank">Xfce4-dev@xfce.org</a>
<a class="m_-3380205898582356286moz-txt-link-freetext" href="https://mail.xfce.org/mailman/listinfo/xfce4-dev" target="_blank">https://mail.xfce.org/mailman/<wbr>listinfo/xfce4-dev</a></pre>
    </blockquote>
    <br>
  </div>

<br>______________________________<wbr>_________________<br>
Xfce4-dev mailing list<br>
<a href="mailto:Xfce4-dev@xfce.org">Xfce4-dev@xfce.org</a><br>
<a href="https://mail.xfce.org/mailman/listinfo/xfce4-dev" rel="noreferrer" target="_blank">https://mail.xfce.org/mailman/<wbr>listinfo/xfce4-dev</a><br></blockquote></div><br></div>