<div dir="ltr">Hi,<div><br></div><div>Good work! Something minor, the buttons are not properly centered for me. I don't have many GTK3 apps installed so I hope this example will suffice: <a href="http://imgur.com/a/yyVIZ">http://imgur.com/a/yyVIZ</a> I also updated the bug report for the weird artefacting on Bugzilla. Let me know if I can be of any more help.</div></div><div class="gmail_extra"><br><div class="gmail_quote">On Thu, Apr 13, 2017 at 5:48 AM, André Miranda <span dir="ltr"><<a href="mailto:andre42m@gmail.com" target="_blank">andre42m@gmail.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">Hi guys!<br>
I'd like to announce the completion of xfce4-screenshooter port to GTK3:<br>
<a href="https://github.com/andreldm/xfce4-screenshooter" rel="noreferrer" target="_blank">https://github.com/andreldm/xf<wbr>ce4-screenshooter</a><br>
<br>
So I call for tests and eventual merge to official repository.<br>
<br>
The pending deprecations (I was told to not worry about them for now) are:<br>
gdk_device_grab<br>
gdk_device_ungrab<br>
gdk_screen_get_active_window<br>
gdk_screen_get_height<br>
gdk_screen_get_width<br>
gdk_window_process_all_updates<br>
gtk_widget_get_style<br>
soup_xmlrpc_parse_method_respo<wbr>nse<br>
soup_xmlrpc_build_method_call<br>
<br>
Also a sudden crash affects xfce4-screenshooter, I thought this was introduced by my changes, but this defect is present on current master but not version 1.8.2, so I guess this was a successful 1:1 port ^^<br>
The problem is easy to reproduce, try to upload to zimagez, cancel when asked for credentials and you get a nice backtrace and memory map on your terminal. This also affects failed uploads to imgur, just pull the ethernet cable and try to upload.<br>
Here are my findings, though I wasn't able to fix:<br>
<br>
1c462a0 - Port from deprecated GValueArray to GArray<br>
Bug *probably* introduced here, works but parameter strings are broken.<br>
<br>
Crash in screenshooter_simple_job_final<wbr>ize (GObject *object)<br>
/* release the param values */<br>
- g_value_array_free (simple_job->param_values);<br>
+ g_array_unref (simple_job->param_values); <-- Here<br>
<br>
More precisely here (on the second pass):<br>
<a href="https://github.com/GNOME/glib/blob/e5ed410c8c0fe823883b65b293fb2d9c9d12673a/glib/garray.c#L362" rel="noreferrer" target="_blank">https://github.com/GNOME/glib/<wbr>blob/e5ed410c8c0fe823883b65b29<wbr>3fb2d9c9d12673a/glib/garray.c#<wbr>L362</a><br>
<br>
6de6b7e - Fix crash in GValueArray handling (#11879)<br>
Causes: assertion failed: (err != NULL || exo_job_is_cancelled (job))<br>
[1] 12539 abort (core dumped) src/xfce4-screenshooter<br>
<br>
4569b71 - Fix crash when uploading to zimagez, followup to 6de6b7e (#11879)<br>
Fixes the previous crash but the current crash is already present.<br>
<br>
______________________________<wbr>_________________<br>
Xfce4-dev mailing list<br>
<a href="mailto:Xfce4-dev@xfce.org" target="_blank">Xfce4-dev@xfce.org</a><br>
<a href="https://mail.xfce.org/mailman/listinfo/xfce4-dev" rel="noreferrer" target="_blank">https://mail.xfce.org/mailman/<wbr>listinfo/xfce4-dev</a></blockquote></div><br></div>