<html>
<head>
<meta content="text/html; charset=windows-1252"
http-equiv="Content-Type">
</head>
<body text="#000000" bgcolor="#FFFFFF">
<div class="moz-cite-prefix">For tabs vs spaces, I realized this
after committing the code. I dunno which recent updated plugin
made my gvim uses tabs instead of spaces, I'll fix that.<br>
<br>
Cheers,<br>
Ali<br>
<br>
On 10/14/2015 12:19 AM, Simon Steinbeiss wrote:<br>
</div>
<blockquote
cite="mid:CAApLaz2=nNOm=B88sHOTe183SY=beRQz2d6OMUVaD2k_OWFQ+g@mail.gmail.com"
type="cite">
<div dir="ltr">
<div class="gmail_quote">
<div dir="ltr">On Tue, Oct 13, 2015 at 6:17 PM Ali Abdallah
<<a moz-do-not-send="true" href="mailto:aliovx@gmail.com">aliovx@gmail.com</a>>
wrote:<br>
</div>
<blockquote class="gmail_quote" style="margin:0 0 0
.8ex;border-left:1px #ccc solid;padding-left:1ex">Yes it is
a bit ugly. I will fix it. I see that the section<br>
'.app-notification' is present in all my gtk-3 themes that I
have. So<br>
maybe I can fallback to this section of the current theme.<br>
<br>
Cheers,<br>
Ali<br>
</blockquote>
<div><br>
</div>
<div>Hey Ali,</div>
<div><br>
</div>
<div>first of all the whole thing works nicely and looks
almost like the Gtk2 variant. Obviously a lot more is
possible with Gtk3 but that's up to the themes. One notable
difference to the current release of xfce4-notifyd is the
summary, which is bold (yeah, typo-alarm in
Smoke/gtk.css:21) and not centered but left-aligned (which I
think makes sense). But apart from these tiny cosmetica you
did a great job here!</div>
<div>(I also noticed quite some indent inconsistency - tabs
versus spaces etc. Now I know some consider this nit-picky,
but to me it's part of the code quality.)<br>
</div>
<div><br>
</div>
<div>With respect to using pre-existing classes for styling
this window by default I would stick to whatever is present
in Adwaita, which recently turned from the de-facto standard
in Gtk3 to *the* standard theme (after all, it's the general
fallback now). Plus, I would be hesitant to use any of those
classes as it's not always clear in what contexts they are
or will be used. E.g. what if the .app-notification class
doesn't really work well for notifyd anymore in Gtk3.20
because the Gnome Design team decides to use it for
something odd from our POV?</div>
<div><br>
</div>
<div>Personally for system style I'd still go down to colors
and set some reasonable ones and also set some other
reasonable default values for borders, border-radius etc.
(Basically just something that isn't ZOMG Ponies!)</div>
<div><br>
</div>
<div>Cheers</div>
<div>Simon</div>
</div>
</div>
<br>
<fieldset class="mimeAttachmentHeader"></fieldset>
<br>
<pre wrap="">_______________________________________________
Xfce4-dev mailing list
<a class="moz-txt-link-abbreviated" href="mailto:Xfce4-dev@xfce.org">Xfce4-dev@xfce.org</a>
<a class="moz-txt-link-freetext" href="https://mail.xfce.org/mailman/listinfo/xfce4-dev">https://mail.xfce.org/mailman/listinfo/xfce4-dev</a></pre>
</blockquote>
<br>
</body>
</html>