<div dir="ltr"><br><div class="gmail_extra"><br><div class="gmail_quote">On Wed, Feb 4, 2015 at 8:29 PM, Guido Berhoerster <span dir="ltr"><<a href="mailto:gber@opensuse.org" target="_blank">gber@opensuse.org</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left-width:1px;border-left-color:rgb(204,204,204);border-left-style:solid;padding-left:1ex">* Peter de Ridder <<a href="mailto:peter@xfce.org">peter@xfce.org</a>> [2015-02-04 20:12]:<br>
<span class="">> The discussion on the gtk3 theme has come to an end.<br>
> What does this mean for the xfce gtk engine?<br>
><br>
> The current state of the engine:<br>
> Gtk2 some fixes in the refresh branch since last release.<br>
> Gtk3 themes that worked ok until 3.4. The engine code needs to be checked<br>
> with the latest version.<br>
><br>
> What should we do with the Gtk3 part of the engine?<br>
> Engine code:<br>
> 1) Drop it completely<br>
> 2) Fix the code to work with the latest versions<br>
> 3) Reduce the code to only the checkboxes. (The rest can probably be themed<br>
> directly)<br>
<br>
</span>For recent GTK 3 versions there is nothing to fix, 3.14 dropped<br>
support for theme engines. You can only try to port the themes to<br>
CSS...<br>
<span class=""><br></span></blockquote><div><br></div><div><span style="font-size:14px">That would vote for a. Depening on what gtk version we settle for 4.14.</span><br></div><div> </div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left-width:1px;border-left-color:rgb(204,204,204);border-left-style:solid;padding-left:1ex"><span class="">
<br>
> Themes:<br>
> a) Drop them<br>
> b) Leave them as is, and accept patches to get them fixed<br>
> c) Fix the assumed to be used ones (Dusk, Xfce 4.x series)<br>
><br>
> I'll be willing to put some time in this, if we think that is the right way<br>
> to go.<br>
><br>
> In my opinion the xfce engine serves two purposes, provide a default theme<br>
> (gtk2 default is ugly) and provide a light-weight engine for the low end<br>
> machines.<br>
<br>
</span>...however that is not a one time effort, as noted earlier, in the<br>
past every minor release introduced more or less breakage among<br>
themes. And changes affecting themes are not specifically<br>
documented, so you can only try to monitor changes to Adwaita and<br>
work by trial and error.<span class=""><font color="#888888"><a href="https://mail.xfce.org/mailman/listinfo/xfce4-dev" target="_blank"></a></font></span></blockquote><div><br></div><div style="font-size:14px">I know that this won't be one time. But I'll keep it open, in case we want to keep supporting Gtk3 themes.</div><div style="font-size:14px">b won't be a real option as that would only work below 3.14.</div><div style="font-size:14px">So either a or c. Do we want to provide Gtk3 themes once we switch to gtk3 (4.14)?</div><div style="font-size:14px">imo, a means this will be the last xfce release for the engine.<br></div><div style="font-size:14px">c means we want to keep providing (Gtk3) themes for future xfce releases.</div><div style="font-size:14px"><br></div><div style="font-size:14px">Regards,</div><div><span style="font-size:14px">Peter</span> </div></div><br></div></div>