<html>
<head>
<meta content="text/html; charset=windows-1252"
http-equiv="Content-Type">
</head>
<body bgcolor="#FFFFFF" text="#000000">
Hello Sonal,<br>
First of all, thank you. This is an awesome feature, I guess lots of
folks are waiting for this.<br>
I've just tried and it seems to be working great, even clicking on
item is now possible.<br>
But unfortunatelly I'm experiencing crashes, here are two stderr:<br>
<br>
(xfwm4:8264): GLib-GObject-CRITICAL **: g_param_spec_int: assertion
'default_value >= minimum && default_value <= maximum'
failed<br>
<br>
(xfwm4:8264): Gtk-CRITICAL **:
IA__gtk_widget_class_install_style_property: assertion
'G_IS_PARAM_SPEC (pspec)' failed<br>
<br>
---<br>
<br>
(xfwm4:1845): GLib-GObject-CRITICAL **: g_param_spec_int: assertion
'default_value >= minimum && default_value <= maximum'
failed<br>
<br>
(xfwm4:1845): Gtk-CRITICAL **:
IA__gtk_widget_class_install_style_property: assertion
'G_IS_PARAM_SPEC (pspec)' failed<br>
<br>
Other than that, what I miss are the applications icons. Do you plan
to add them next to the windows previews?<br>
<br>
Cheers,<br>
André Miranda<br>
<br>
<div class="moz-cite-prefix">On 11-01-2015 11:32, Sonal Santan
wrote:<br>
</div>
<blockquote
cite="mid:CABz2wXR0RiCAk-ucDO7T0Db-FCU5RVO09yq+3+D8P4hSS-4Jtw@mail.gmail.com"
type="cite">
<div dir="ltr">
<div>Hello,<br>
<br>
I think I have solved that bug. Now I request for preview
caching in clientWithdrawSingle() which works reliably for all
applications. I have pushed the changes to github. Please give
it a try.<br>
<br>
</div>
-Sonal<br>
</div>
<div class="gmail_extra"><br>
<div class="gmail_quote">On Sat, Jan 10, 2015 at 5:42 PM, Sonal
Santan <span dir="ltr"><<a moz-do-not-send="true"
href="mailto:sonal.santan@gmail.com" target="_blank">sonal.santan@gmail.com</a>></span>
wrote:<br>
<blockquote class="gmail_quote" style="margin:0 0 0
.8ex;border-left:1px #ccc solid;padding-left:1ex">
<div dir="ltr">
<div>Hello,<br>
<br>
The missing preview bug I mentioned in my previous email
seems to only affect XFCE Terminal if that makes any
sense.<span class="HOEnZb"><font color="#888888"><br>
<br>
</font></span></div>
<span class="HOEnZb"><font color="#888888">-Sonal<br>
</font></span></div>
<div class="HOEnZb">
<div class="h5">
<div class="gmail_extra"><br>
<div class="gmail_quote">On Sat, Jan 10, 2015 at 5:25
PM, Sonal Santan <span dir="ltr"><<a
moz-do-not-send="true"
href="mailto:sonal.santan@gmail.com"
target="_blank">sonal.santan@gmail.com</a>></span>
wrote:<br>
<blockquote class="gmail_quote" style="margin:0 0 0
.8ex;border-left:1px #ccc solid;padding-left:1ex">
<div dir="ltr">
<div>
<div>Hello,<br>
<br>
</div>
I have upstreamed my changes for window
previews to <a moz-do-not-send="true"
href="https://github.com/sonals/xfwm4.git"
target="_blank">https://github.com/sonals/xfwm4.git</a>
for folks to try out. There is one bug I am
still trying to track down -- occasionally,
the preview comes out as blank for a minimized
window. I capture the previews of windows
which are about to be minimized inside
unmap_win() hook of the compositor. Is this
the correct location for capturing the
previews of windows which are about to be
minimized?<br>
<br>
</div>
<div>For folks who are curious, the new
function, update_win_preview() defined in
compositor.c captures the previews. XImage to
GdkPixbuf conversion happens in the new
function, gdk_pixbuf_xlib_get_from_image()
defined in a new file previews.c. <br>
<br>
</div>
<div>Will submit patches to the list after I
have taken care of the bug mentioned above.<span><font
color="#888888"><br>
</font></span></div>
<span><font color="#888888">
<div><br>
</div>
<div>-Sonal<br>
</div>
<div class="gmail_extra"><br>
<div class="gmail_quote"><br>
</div>
<br>
</div>
</font></span></div>
</blockquote>
</div>
<br>
</div>
</div>
</div>
</blockquote>
</div>
<br>
</div>
<br>
<fieldset class="mimeAttachmentHeader"></fieldset>
<br>
<pre wrap="">_______________________________________________
Xfce4-dev mailing list
<a class="moz-txt-link-abbreviated" href="mailto:Xfce4-dev@xfce.org">Xfce4-dev@xfce.org</a>
<a class="moz-txt-link-freetext" href="https://mail.xfce.org/mailman/listinfo/xfce4-dev">https://mail.xfce.org/mailman/listinfo/xfce4-dev</a></pre>
</blockquote>
<br>
</body>
</html>