From manfred.h at gmx.net Fri Oct 17 13:45:14 2025 From: manfred.h at gmx.net (Manfred Hollstein) Date: Fri, 17 Oct 2025 13:45:14 +0200 Subject: ANNOUNCE: thunar 4.21.3 released In-Reply-To: <68f092576d82c_1df1068283e@xfce2.mail> References: <68f092576d82c_1df1068283e@xfce2.mail> Message-ID: Hi there, On Thu, 16 Oct 2025, 08:36:07 +0200, Alexander Schwinn wrote: > thunar 4.21.3 is now available for download from > > https://archive.xfce.org/src/xfce/thunar/4.21/thunar-4.21.3.tar.xz > https://archive.xfce.org/src/xfce/thunar/4.21/thunar-4.21.3.tar.xz?sha1 > https://archive.xfce.org/src/xfce/thunar/4.21/thunar-4.21.3.tar.xz?sha256 while "terminal" is an optional feature, thunar/thunar-preferences.c uses some of the optional constants unconditionally. If vte-devel is not installed in the build environment, building the new version fails. The patch below fixes this. HTH, cheers. l8er manfred - Properly wrap all occurrences of PROP_TERMINAL_* in thunar/thunar-preferences.c diff -rup a/thunar/thunar-preferences.c b/thunar/thunar-preferences.c --- a/thunar/thunar-preferences.c 2025-10-16 08:22:21.000000000 +0200 +++ b/thunar/thunar-preferences.c 2025-10-17 13:37:12.009861792 +0200 @@ -1498,6 +1498,7 @@ thunar_preferences_class_init (ThunarPre THUNAR_FILE_DRAG_MODE_MENU_ALWAYS, G_PARAM_READWRITE | G_PARAM_STATIC_STRINGS); +#ifdef HAVE_VTE /** * ThunarPreferences:terminal-height: * @@ -1511,7 +1512,9 @@ thunar_preferences_class_init (ThunarPre G_MAXINT, /* max height */ 200, /* default height */ G_PARAM_READWRITE | G_PARAM_STATIC_STRINGS); +#endif +#ifdef HAVE_VTE /** * ThunarPreferences:terminal-visible: * @@ -1523,7 +1526,9 @@ thunar_preferences_class_init (ThunarPre NULL, FALSE, G_PARAM_READWRITE | G_PARAM_STATIC_STRINGS); +#endif +#ifdef HAVE_VTE /** * ThunarPreferences:terminal-color-scheme: * @@ -1535,7 +1540,9 @@ thunar_preferences_class_init (ThunarPre NULL, "system", G_PARAM_READWRITE | G_PARAM_STATIC_STRINGS); +#endif +#ifdef HAVE_VTE /** * ThunarPreferences:terminal-sync-mode: * @@ -1548,7 +1555,9 @@ thunar_preferences_class_init (ThunarPre THUNAR_TYPE_TERMINAL_SYNC_MODE, THUNAR_TERMINAL_SYNC_BOTH, G_PARAM_READWRITE | G_PARAM_STATIC_STRINGS); +#endif +#ifdef HAVE_VTE /** * ThunarPreferences:terminal-ssh-auto-connect: * @@ -1560,7 +1569,9 @@ thunar_preferences_class_init (ThunarPre NULL, FALSE, G_PARAM_READWRITE | G_PARAM_STATIC_STRINGS); +#endif +#ifdef HAVE_VTE /** * ThunarPreferences:terminal-ssh-auto-disconnect: * @@ -1572,6 +1583,7 @@ thunar_preferences_class_init (ThunarPre NULL, FALSE, G_PARAM_READWRITE | G_PARAM_STATIC_STRINGS); +#endif #ifdef HAVE_VTE /** -------------- next part -------------- A non-text attachment was scrubbed... Name: signature.asc Type: application/pgp-signature Size: 870 bytes Desc: not available URL: From acs82 at gmx.de Fri Oct 17 14:16:55 2025 From: acs82 at gmx.de (Alexander Schwinn) Date: Fri, 17 Oct 2025 14:16:55 +0200 Subject: ANNOUNCE: thunar 4.21.3 released In-Reply-To: References: <68f092576d82c_1df1068283e@xfce2.mail> Message-ID: <281afe14-6eec-4cb3-a7a6-028a34267191@gmx.de> Thank you for the patch Manfred! However there is already a related issue and a MR with the fix: https://gitlab.xfce.org/xfce/thunar/-/issues/1735 https://gitlab.xfce.org/xfce/thunar/-/merge_requests/719 BR, Alexander Schwinn Am 17.10.25 um 13:45 schrieb Manfred Hollstein: > Hi there, > > On Thu, 16 Oct 2025, 08:36:07 +0200, Alexander Schwinn wrote: >> thunar 4.21.3 is now available for download from >> >> https://archive.xfce.org/src/xfce/thunar/4.21/thunar-4.21.3.tar.xz >> https://archive.xfce.org/src/xfce/thunar/4.21/thunar-4.21.3.tar.xz?sha1 >> https://archive.xfce.org/src/xfce/thunar/4.21/thunar-4.21.3.tar.xz?sha256 > while "terminal" is an optional feature, thunar/thunar-preferences.c > uses some of the optional constants unconditionally. If vte-devel is not > installed in the build environment, building the new version fails. The > patch below fixes this. > > HTH, cheers. > > l8er > manfred > > > - Properly wrap all occurrences of PROP_TERMINAL_* in thunar/thunar-preferences.c > > > diff -rup a/thunar/thunar-preferences.c b/thunar/thunar-preferences.c > --- a/thunar/thunar-preferences.c 2025-10-16 08:22:21.000000000 +0200 > +++ b/thunar/thunar-preferences.c 2025-10-17 13:37:12.009861792 +0200 > @@ -1498,6 +1498,7 @@ thunar_preferences_class_init (ThunarPre > THUNAR_FILE_DRAG_MODE_MENU_ALWAYS, > G_PARAM_READWRITE | G_PARAM_STATIC_STRINGS); > > +#ifdef HAVE_VTE > /** > * ThunarPreferences:terminal-height: > * > @@ -1511,7 +1512,9 @@ thunar_preferences_class_init (ThunarPre > G_MAXINT, /* max height */ > 200, /* default height */ > G_PARAM_READWRITE | G_PARAM_STATIC_STRINGS); > +#endif > > +#ifdef HAVE_VTE > /** > * ThunarPreferences:terminal-visible: > * > @@ -1523,7 +1526,9 @@ thunar_preferences_class_init (ThunarPre > NULL, > FALSE, > G_PARAM_READWRITE | G_PARAM_STATIC_STRINGS); > +#endif > > +#ifdef HAVE_VTE > /** > * ThunarPreferences:terminal-color-scheme: > * > @@ -1535,7 +1540,9 @@ thunar_preferences_class_init (ThunarPre > NULL, > "system", > G_PARAM_READWRITE | G_PARAM_STATIC_STRINGS); > +#endif > > +#ifdef HAVE_VTE > /** > * ThunarPreferences:terminal-sync-mode: > * > @@ -1548,7 +1555,9 @@ thunar_preferences_class_init (ThunarPre > THUNAR_TYPE_TERMINAL_SYNC_MODE, > THUNAR_TERMINAL_SYNC_BOTH, > G_PARAM_READWRITE | G_PARAM_STATIC_STRINGS); > +#endif > > +#ifdef HAVE_VTE > /** > * ThunarPreferences:terminal-ssh-auto-connect: > * > @@ -1560,7 +1569,9 @@ thunar_preferences_class_init (ThunarPre > NULL, > FALSE, > G_PARAM_READWRITE | G_PARAM_STATIC_STRINGS); > +#endif > > +#ifdef HAVE_VTE > /** > * ThunarPreferences:terminal-ssh-auto-disconnect: > * > @@ -1572,6 +1583,7 @@ thunar_preferences_class_init (ThunarPre > NULL, > FALSE, > G_PARAM_READWRITE | G_PARAM_STATIC_STRINGS); > +#endif > > #ifdef HAVE_VTE > /** > > _______________________________________________ > Xfce4-dev mailing list > Xfce4-dev at xfce.org > https://mail.xfce.org/mailman/listinfo/xfce4-dev